Draft
Conversation
b916c17 to
392c6de
Compare
timirwin
approved these changes
Apr 6, 2026
justwiebe
reviewed
Apr 6, 2026
| class McpGenerator < GeneratorBase | ||
| source_root File.expand_path('templates', __dir__) | ||
|
|
||
| def update_inflections |
Contributor
There was a problem hiding this comment.
Is the generator going to be able to be run a second time if the inflections are setup? Or don't inflections affect gems?
Member
Author
There was a problem hiding this comment.
just testing on the example app, host application inflections do not affect gem file loading. Which I think makes sense. Rails inflections affect constant look up because they're tied into the Rails autoloader, but RMR's generators are not loaded by the Zeitwerk autoloader. They are just added to the Ruby FILE_PATH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
BaseGenerator sounds like it's a generator itself, but it's not. It also shows up in the list of available generators for the consumer app, which it shouldn't.
What Changed
What changed in this PR?
BaseGeneratortoGeneratorBaseGeneratorBaseout ofrolemodel/generatorsdirectorybin/new_generatoroutputbin/recreate_current_examplegeneratorPre-merge checklist
bin/bump_versionorbin/bump_version --patchScreenshots