[CyberpunkRED_raycw] New Features: Added initiative modifier and aimed shot button

[spako]

Submission Checklist

Warning

Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. Deleting parts of this template (except the new sheet section for existing sheets) counts as failure to complete it. If you have any questions, please feel free to create an issue.

Note

Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.

Pull Request Title

Please format your pull request in the following way: [Sheet Name] Change Type: Description. For example: [D&D5e] New Feature: Adding dragons to dungeons.

• The pull request title clearly contains the name of the sheet I am editing.
• The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

Pull Request Content

• The pull request makes changes to files in only one sub-folder.
• The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)
• The pull request does not, without express prior permission from affected parties, include any material that could be considered to infringe on a Publisher's intellectual property rights, such as logos, images, rules text or other rules content.

Changes / Description

• An initiative modifer input can be added to the main sheet via a setting, default is to hide.
• If enabled the initiative modifier will be added to the initiative roll, default is 0.
• An aimed shot "button" can be added to each weapon via a setting, default is to hide.
• The aimed shot button is a red crosshair icon to help it fit into the existing layout.
• The aimed shot penalty will be applied to an attack role.
• The aimed shot penalty defaults to -8 and can be configured for homebrew games.
• Fixed repeating_weapons missing background when overflowing.
• Improved settings sheet styling.
• These changes do not impact any existing functionaliy of the sheet, based on default values.

Tested in custom sheet sandbox #20415307.

[roll20deploy]

Character Sheet Info Roll20 Internal Use only.

[spako]

Hey @ray-cw just pinging you in case you wanted to check the PR.

[BronsonHall]

Hey @spako

As per your comment, putting this on hold pending a review for now

[spako]

@BronsonHall the original author was tagged as per the guidelines. There have been previous PRs for this character sheet set in 2022 made by other people that were not reviewed by the original author. What happens if the original author is not able to review?

If there is a preference to maintain the sheet’s current functionality by default, the new features can be put behind “Settings” that need to be enabled. Would this increase the chances of the features to be merged?

[davidroll20]

Hi @spako - we typically give the original author about 2 weeks to review. If they don't get to it by then, we'll go ahead with the PR. Making changes optional is a neat idea to allow users to opt-in! That said, it's not the primary reason we wait for the original author to take a look - we want to make sure that they have the chance to identify any issues with the new code or flag any potential conflicts with incoming work.

I'll tag @ray-cw here again to give another push on this, but beyond that, we'll just need to wait!

Thank you for your contribution - and your patience!

[spako]

@davidroll20 fair enough, happy to wait, thanks for explaining the process!

Just FYI, I did also DM the author on Roll20 the other day.

In the meantime, I'll look at making the new features optional and will push updates here.

[spako]

@davidroll20 @BronsonHall the new features are now optional and they default to being hidden. The main description has been updated with more detail.