Open
Conversation
ColeFMeldorf
requested review from
Copilot,
rknop and
wmwv
and removed request for
Copilot
wmwv
requested changes
Feb 3, 2026
Contributor
wmwv
left a comment
wmwv
left a comment
There was a problem hiding this comment.
Update changelog message to be more correct in its description in the updated context.
| @@ -0,0 +1 @@ | |||
| Reduced memory for blank images No newline at end of file | |||
| input_header["BAND"] = image_object.band | ||
| input_header["POINTING"] = image_object.pointing | ||
| input_header["SCA"] = image_object.sca | ||
| image_object.data = np.zeros((4088, 4088)) |
Contributor
There was a problem hiding this comment.
These changes to simulation.py will trigger a merge conflict.
wmwv
reviewed
Feb 7, 2026
|
|
||
| image_object.data = None | ||
| image_object.noise = None | ||
| image_object.flags = None # These are meaningless, delete to save memory. |
Contributor
There was a problem hiding this comment.
Does this comment apply only to flags, or to data, noise, and flags?
| input_header["BAND"] = image_object.band | ||
| input_header["POINTING"] = image_object.pointing | ||
| input_header["SCA"] = image_object.sca | ||
| image_object.data = np.zeros((4088, 4088)) |
Contributor
There was a problem hiding this comment.
Define 4088 somewhere as a variable and use that consistently.
Possibly something like
nx, ny = 4088, 4088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank images were being generated with large (4088x4088) arrays of zeros that were a waste of memory.
/dev/nulls and replaced them withNones as I was able to make those changes insnapplsimultaneously.This PR is dependent on snappl PR 81