Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add the ability for galsim ou2024 PSFs to draw galaxies in the same way that the gaussian galaxies do. This is literally a copy and paste. There are some small notes for the tests however:
1.) The OU24 PSF is assymetric. I use the same assymetric Center of Mass offset as Rob does in his center of mass check for testing the PSF as it renders a point source, so I think this is fine.
2.) For some reason, the photon shot PSF galaxies of ~0.3% more flux than the non photon shot one. Do we think this is a concern?