Refactor Modular Navigation With Framework-Neutral APIs#854
Open
dev-bilal-azzam wants to merge 2 commits into
Open
Conversation
dev-bilal-azzam
commented
Aug 25, 2025
dev-bilal-azzam
commented
Contributor
- Refactor HomeApi to be framework-independent "without depending on compose or xml"
- Use HomeActivity to hold the Main features grouped in bottom navigation bar
dev-bilal-azzam
requested review from
AhmedMohamed056,
Ashraf-El-Fallah,
HendSayed25,
K-M-9,
Mohamed-Ashraf-2210,
Mostafa-khaled21,
devfalah,
devsadeq,
doaaabdelnaser,
mahmmedn19,
mohamedebrahem13,
mohannadahmed00,
poula22,
skaik-mo and
yassenRamadan1
as code owners
devfalah
reviewed
Aug 26, 2025
|
|
||
| interface HomeApi { | ||
|
|
||
| fun launchHome(context: Context) |
Contributor
There was a problem hiding this comment.
you can inject the context directly into the HomeApiImp
devfalah
reviewed
Aug 26, 2025
| override fun launchHome(context: Context) { | ||
| val intent = Intent(context, HomeActivity::class.java) | ||
| context.startActivity(intent) | ||
| if (context is Activity) context.finish() |
Contributor
There was a problem hiding this comment.
I think we dont need this line?
devfalah
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.