-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Clarify checkpointing git phrasing #8392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clarify checkpointing git phrasing #8392
Conversation
…ed related error messages
…fy-checkpointing-git-phrasing
…ed related error messages
…om/jfcantu/Roo-Code into clarify-checkpointing-git-phrasing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR clarifies the error message and terminology used when checkpointing cannot be enabled due to Git repositories existing below the workspace root. The changes replace the potentially confusing term "nested" with "child" throughout the codebase and improve the error message clarity.
- Replaces "nested" terminology with "child" for better clarity
- Updates error message to be more informative and includes documentation link
- Updates corresponding test descriptions and variable names
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/services/checkpoints/ShadowCheckpointService.ts | Updates method names, variable names, and error messages from "nested" to "child" terminology |
src/services/checkpoints/tests/ShadowCheckpointService.spec.ts | Updates test descriptions, variable names, and expected error message patterns to match new terminology |
src/i18n/locales/en/common.json | Updates the internationalized error message with clearer wording and adds documentation link |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
const relativePath = path.relative(this.workspaceDir, nestedGitPath) | ||
const message = t("common:errors.nested_git_repos_warning", { path: relativePath }) | ||
const relativePath = path.relative(this.workspaceDir, childGitPath) | ||
const message = t("common:errors.child_git_repos_warning", { path: relativePath }) |
Copilot
AI
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation key references 'child_git_repos_warning' but the JSON file still uses 'nested_git_repos_warning'. This will cause the translation to fail.
Copilot uses AI. Check for mistakes.
"checkpoint_failed": "Failed to restore checkpoint.", | ||
"git_not_installed": "Git is required for the checkpoints feature. Please install Git to enable checkpoints.", | ||
"nested_git_repos_warning": "Checkpoints are disabled because a nested git repository was detected at: {{path}}. To use checkpoints, please remove or relocate this nested git repository.", | ||
"nested_git_repos_warning": "Checkpoints are disabled because a Git repository was detected below the workspace root at: {{path}}. To use checkpoints, please remove or relocate this git repository, or open a Git repository as the workspace root.\n\nFor more information, see https://docs.roocode.com/features/checkpoints#git-repositories-below-the-workspace-root", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical consistency: The string uses "Git repository" earlier but refers to it as "git repository" later on this line. Consider using a consistent capitalization (e.g., "Git repository") throughout.
"nested_git_repos_warning": "Checkpoints are disabled because a Git repository was detected below the workspace root at: {{path}}. To use checkpoints, please remove or relocate this git repository, or open a Git repository as the workspace root.\n\nFor more information, see https://docs.roocode.com/features/checkpoints#git-repositories-below-the-workspace-root", | |
"nested_git_repos_warning": "Checkpoints are disabled because a Git repository was detected below the workspace root at: {{path}}. To use checkpoints, please remove or relocate this Git repository, or open a Git repository as the workspace root.\n\nFor more information, see https://docs.roocode.com/features/checkpoints#git-repositories-below-the-workspace-root", |
Related GitHub Issue
Addresses: #8164
(I discussed this with @hannesrudolph on Discord, who indicated not to worry about creating a new issue.)
Roo Code Task Context (Optional)
Description
What:
Why:
The term "nesting" can be confusing, as it implies the issue is "git repository inside a git repository", which may not be the case.
How:
Test Procedure
I ran
pnpm test
as described.I received this error several times, but it appears to be related to my local build environment, not to my changes:
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
PR for documentation update has been submitted: RooCodeInc/Roo-Code-Docs#373
Additional Notes
Get in Touch
Important
Clarified Git repository detection terminology in checkpointing by replacing 'nested' with 'child' and updated related error messages and tests.
common.json
for Git repository detection, replacing 'nested' with 'child' and adding a documentation link.ShadowCheckpointService.ts
to use 'child' instead of 'nested' in error handling and logging.getNestedGitRepository()
togetChildGitRepository()
inShadowCheckpointService.ts
.ShadowCheckpointService.spec.ts
to reflect terminology change from 'nested' to 'child'.This description was created by
for 3e1b9fc. You can customize this summary. It will automatically update as commits are pushed.