Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Oct 16, 2025

Summary

This PR updates the @modelcontextprotocol/sdk dependency from version 1.12.0 to 1.20.0 to add support for MCP servers using protocol version "2025-06-18".

Problem

As reported in #8683, Roo was unable to connect to MCP servers implementing the 2025-06-18 protocol version, showing the error:

Server's protocol version is not supported: 2025-06-18

This was because the SDK version 1.12.0 only supported protocol versions up to 2025-03-26. Support for 2025-06-18 was added in SDK version 1.13.0.

Solution

  • Updated @modelcontextprotocol/sdk from 1.12.0 to 1.20.0 in src/package.json
  • Added type casting in McpHub.ts to maintain backward compatibility with the existing McpToolCallResponse type structure

Changes

  • src/package.json: Updated MCP SDK dependency version
  • pnpm-lock.yaml: Updated lock file with new dependency version
  • src/services/mcp/McpHub.ts: Added type casting for CallToolResultSchema compatibility

Testing

  • ✅ All existing MCP tests pass (McpHub.spec.ts, useMcpToolTool.spec.ts)
  • ✅ TypeScript compilation successful
  • ✅ Lint checks pass

Impact

This is a non-breaking change that extends MCP server compatibility to include servers using the 2025-06-18 protocol version.

Fixes #8683


Important

Update MCP SDK to v1.20.0 for 2025-06-18 protocol support and add type casting for backward compatibility.

  • Dependencies:
    • Update @modelcontextprotocol/sdk from 1.12.0 to 1.20.0 in package.json for 2025-06-18 protocol support.
  • Type Casting:
    • Add type casting for CallToolResultSchema in McpHub.ts to maintain backward compatibility with McpToolCallResponse.
  • Testing:
    • All existing tests pass (McpHub.spec.ts, useMcpToolTool.spec.ts).
    • TypeScript compilation and lint checks successful.
  • Impact:
    • Non-breaking change extending MCP server compatibility to 2025-06-18 protocol version.

This description was created by Ellipsis for 0b9fc4c. You can customize this summary. It will automatically update as commits are pushed.

…ol support

Updates the MCP SDK from version 1.12.0 to 1.20.0 to add support for protocol
version 2025-06-18. This resolves the "Server protocol version is not supported"
error when connecting to MCP servers using the newer protocol.

Fixes #8683
… v1.20.0

The SDK v1.20.0 has a different response type structure. Added type casting
to maintain backward compatibility with the existing McpToolCallResponse type.
@roomote
Copy link
Author

roomote bot commented Oct 16, 2025

Code Review Summary

Review Complete - No Issues Found

I've thoroughly reviewed this pull request and found no issues that require changes.

Changes Reviewed

  • ✅ Dependency update: @modelcontextprotocol/sdk from 1.12.0 to 1.20.0
  • ✅ Type casting added in McpHub.ts for backward compatibility
  • ✅ Lock file updates in pnpm-lock.yaml

Validation

  • All existing MCP tests pass as reported
  • TypeScript compilation successful
  • Lint checks pass
  • The type cast maintains compatibility with existing McpToolCallResponse type structure

The changes are minimal, focused, and achieve the stated goal of adding support for MCP servers using protocol version 2025-06-18.

Recommendation:Approve

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 16, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 16, 2025
@hsuyuming
Copy link

hsuyuming commented Oct 16, 2025

I can connect to the MCP server using Roo and mcp-remote. However, when I set up a basic Roo configuration with the type set to "streamable-http", I receive the following error: "Streamable HTTP error: Failed to open SSE stream: Not Acceptable".

  • mcp-remote
Screenshot 2025-10-16 at 9 10 57 AM
  • Roo configuration with the type set to "streamable-http"
{
  "mcpServers": {
    "snowflake-mcp2": {
      "type": "streamable-http",
      "url": "https://<domain>/mcp>",
      "headers": {
        "Authorization": "Bearer <token>"
      },
      "disabled": false,
      "alwaysAllow": []
    },
  }
}
Screenshot 2025-10-16 at 9 24 30 AM

@hsuyuming
Copy link

hsuyuming commented Oct 16, 2025

Maybe this is the MCP server issue, investigating

@hsuyuming
Copy link

It appears that the issue is due to the mcp server only supporting non-streaming responses. So this PR should be good
https://docs.snowflake.com/en/user-guide/snowflake-cortex/cortex-agents-mcp

Screenshot 2025-10-16 at 10 26 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Doesn't support MCP 2025-06-18 protocol version

3 participants