Fix symmetry & abspath issues - #118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two issues in the inference utilities: fixing symmetry detection logic and improving absolute path resolution for input files.
- Enhanced symmetry specification checking to handle None values properly
- Added validation for relative path resolution when no base path is provided
- Improved type annotations for the
ensure_input_is_abspathfunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@Ubiquinone-dot I've opened a new pull request, #119, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Ubiquinone-dot <66851659+Ubiquinone-dot@users.noreply.github.com>
Co-authored-by: Ubiquinone-dot <66851659+Ubiquinone-dot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add missing DesignInputSpecification import and fix path validation logic
Ubiquinone-dot
force-pushed
the
fix/inputspecification
branch
from
December 18, 2025 15:07
16e227d to
eebbf34
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #115, #116 and #117