-
Notifications
You must be signed in to change notification settings - Fork 112
Bump to 2.0.0 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump to 2.0.0 #195
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b794b7b
bump to 2.0.0
yukideluxe 58d261d
drop support for Ruby < 3.1 and add jruby ruby-versions for tests
yukideluxe 4a2bc2c
fixes after bumping money to 7.0.0
yukideluxe 4f6cae1
Remove extra cents
sunny 016b6d3
Spec fix
sunny 7e97b2d
remove unnecessary encoding declarations
yukideluxe 2e8218e
simplify Gemfile since we dropped support for old ruby versions
yukideluxe e1383a3
move dev dependencies to the Gemfile and :nail_care: changes
yukideluxe fcb8ff7
align gemspec style to the one of the money gem
yukideluxe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # encoding: utf-8 | ||
|
|
||
| module Monetize | ||
| VERSION = '1.13.0' | ||
| VERSION = '2.0.0' | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunny I found the commit that caused this! RubyMoney/money@5c71447
Before adding the
@default_currency.nil?condition, the code was initializing a currency withMoney::Currency.new(nil)and then theMoney::Currency::UnknownCurrencywhich was causingMoney.default_currencyto raise that error.One could argue that we should differentiate between the
Money::Currency::NoCurrencyandMoney::Currency::UnknownCurrencyerrors but I think this is OK to avoid touching more code and keep backwards compatibility. We are wrapping the error onMonetize::ParseErrorinstead, anyways! ππ»There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for looking more into this! ππ»