Skip to content

fix: pipeline error cargo audit #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bansikah22 wants to merge 1 commit into from
Closed

fix: pipeline error cargo audit #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
run: cargo doc --workspace --all-features --no-deps

- name: Install cargo-audit
run: cargo install cargo-audit
run: cargo install cargo-audit --force

- name: Run Security Audit
run: cargo audit
Comment on lines +59 to 62
Copy link
Collaborator

@onelrian onelrian Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bansikah22 👋🏽

Instead of:

run: cargo install cargo-audit --force

We could use:

- uses: taiki-e/install-action@v2
  with:
    tool: cargo-audit
- run: cargo audit

It’s faster, avoids compiling from source, and prevents reinstall issues that usually require --force. It’s also designed for CI use and handles caching automatically. Let me know what you think!

Copy link
Collaborator Author

@bansikah22 bansikah22 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onelrian great idea i will update that Thank you

Copy link
Collaborator

@onelrian onelrian Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we're here for
you're welcome

6 changes: 6 additions & 0 deletions ci-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ if ! command -v cargo-audit &> /dev/null; then
cargo install cargo-audit
fi

# Ensure cargo-nextest is installed
if ! command -v cargo-nextest &> /dev/null; then
echo "Installing cargo-nextest..."
cargo install cargo-nextest --locked
fi

# Run all CI steps locally
echo "Checking Formatting..."
cargo fmt --all -- --check || (echo "Formatting issues found, please run 'cargo fmt' to auto-fix." && exit 1)
Expand Down
Loading