Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of duplicate interface #3396 #3422

Closed
wants to merge 3 commits into from
Closed

Conversation

GS-GOAT
Copy link
Contributor

@GS-GOAT GS-GOAT commented Feb 7, 2025

  • Updated single-parameter calls to pass an explicit HirId alongside the type.

  • This refactor ensures that all calls to insert_implicit_type consistently use the two-parameter version, improving clarity and maintainability of type mapping tracking.

Fixes #3396

- Updated single-parameter calls to pass an explicit HirId alongside the type.

- This refactor ensures that all calls to insert_implicit_type consistently use the two-parameter version, improving clarity and maintainability of type mapping tracking.

Fixes Rust-GCC#3396
@powerboat9
Copy link
Collaborator

Does git clang-format work? It should auto format the code, so it'll pass the formatting checks. You may have to install clang-format, and copy contrib/clang-format to .clang-format in the project root.

As for the changelog checks, you can run this line to enable git gcc-commit-mklog, which should make formatting commit messages easier. You can borrow other aliases from the same file (I'd also recommend gcc-verify) or instead run the entire file as a shell script.

Your commits will also have to be signed off on, as described here. You can do that automatically by passing -s to git commit or git gcc-commit-mklog.

@GS-GOAT GS-GOAT closed this Feb 7, 2025
@powerboat9
Copy link
Collaborator

It's a good PR, you don't have to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of duplicate interface
2 participants