Skip to content

Parse deferred const generics #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

Parse deferred const generics #3886

merged 3 commits into from
Jul 21, 2025

Conversation

CohenArthur
Copy link
Member

  • ast: Use AnonConst for array type sizes
  • hir: Handle deferred const inference variables

@CohenArthur CohenArthur force-pushed the parse-deferred-consts branch from 910132e to 0c31e59 Compare July 9, 2025 09:23
philberty
philberty approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty mentioned this pull request Jul 10, 2025
Open
@CohenArthur
ast: Use AnonConst for array type sizes
aabc175 
gcc/rust/ChangeLog:

	* ast/rust-expr.h: Add handling for deferred consts.
	* ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Likewise.
	* ast/rust-ast.cc (AnonConst::as_string): Likewise.
	(ArrayType::as_string): Likewise.
	* ast/rust-type.h (class ArrayType): Use AnonConst for sizes.
	* parse/rust-parse-impl.h (Parser::parse_anon_const): New function.
	(Parser::parse_slice_or_array_type): Call it.
	* parse/rust-parse.h: Declare it.
@CohenArthur
hir: Handle deferred const inference variables
0aba8f6 
gcc/rust/ChangeLog:

	* hir/rust-ast-lower-expr.cc (ASTLoweringExpr::visit): Handle defered consts.
	* hir/tree/rust-hir-expr.cc (AnonConst::AnonConst): Likewise.
	(AnonConst::operator=): Likewise.
	* hir/tree/rust-hir-expr.h: Likewise.
	* hir/tree/rust-hir-visitor.cc (DefaultHIRVisitor::walk): Likewise.
	* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Likewise.

gcc/testsuite/ChangeLog:

	* rust/compile/deferred_const_inference.rs: New test.
@CohenArthur
chore: ast: Fix formatting in rust-expr.h
8da5614 
gcc/rust/ChangeLog:

	* ast/rust-expr.h: Fix formatting.
@CohenArthur CohenArthur force-pushed the parse-deferred-consts branch from 0c31e59 to 8da5614 Compare July 21, 2025 07:40
@CohenArthur CohenArthur enabled auto-merge July 21, 2025 07:41
@CohenArthur CohenArthur added this pull request to the merge queue Jul 21, 2025
Merged via the queue into Rust-GCC:master with commit 032e053 Jul 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CohenArthur @philberty