Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated crates to use new versions of Dependencies #146

Merged
merged 8 commits into from
Mar 7, 2025

Conversation

Schmiedium
Copy link
Contributor

Most of the project builds and uses the newest version of all the dependencies. The only exception is the nvvm codegen crate which still doesn't build

…t nightly. Had to update the vek, sysinfo, and rayon crates, since they wer pulling in code from dependencies that has long since been broken.

rustc codegen nvvm is still broken, seems to have a number of issues. Once I got Optix installed and setup, I started having trouble with llvm. The build file seems to need llvm-config, which does not ship with precompiled binaries for llvm. I compiled llvm from source, but am still unable to get the build file to find that correctly. There are also a number of regular errors which will need to resolved slowly.
… versions. Going to tackle any breaking changes next
…red by the structs they were contained in. This has been resolved
…thod, which was previously throwing an error
@Schmiedium Schmiedium requested a review from frjnn as a code owner February 27, 2025 01:12
Copy link
Collaborator

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As a minor nit, could you use std::cell::OnceCell now that our MSRV is high enough?

@Schmiedium
Copy link
Contributor Author

Yes! Good catch, I'll update that tomorrow

… to replace with the standardized version from the std library, but the dependency does not seem to be in use anyway
@Schmiedium
Copy link
Contributor Author

So it looks like rustc_nvvm_codegen wasn't using once_cell anyway? I removed the dependency from cargo.toml, so it should be good to go

@LegNeato LegNeato merged commit d00cf26 into Rust-GPU:main Mar 7, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants