Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark functions in float_ext.rs as gpu_only #169

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

Schmiedium
Copy link
Contributor

Different behavior between linux and windows linkers causes windows CI to fail when compiliing crates that need cuda_std.

Microsoft provides this explanation for the linker error.

This link contains the exact reason for the error message. Compiling float_ext for an architecture other than nvptx caused the linker to fail with LNK2019, for the reason linked.

#133 See this issue

Thanks to @jorge-ortega for figuring this out.

Different behavior between linux and windows linkers causes windows CI to fail when compiliing crates that need cuda_std.

https://learn.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk2019?view=msvc-170#you-call-intrinsic-functions-or-pass-argument-types-to-intrinsic-functions-that-arent-supported-on-your-target-architecture

This link contains the exact reason for the error message. Compiling float_ext for an architecture other than nvptx caused the linker to fail with LNK2019, for the reason linked.
@Schmiedium
Copy link
Contributor Author

@LegNeato I see you're working on some new CI changes, do you want me to rebase this on top of that when you're done?

@LegNeato
Copy link
Contributor

@Schmiedium nah, it shouldn't matter as my changes aren't touching what you are doing (linux only)

@LegNeato LegNeato merged commit 792056c into Rust-GPU:main Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants