Fix path_tracer example #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses some review comments. - Updates `sysinfo` in `path_tracer` to latest. - Removes the copy of optix_wrapper.rs used for debugging.
Closed
|
Hmmm, I know these require another install but I wonder if that is the only reason they are disabled in CI. I'll file a followup to make a job for this, otherwise it will regress. Thanks @trigpolynom and @jorge-ortega 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally #162
Fixes path_tracer example to build and run. Still some runtime errors when closing the crab ui, and can sometime AV when closing the app.