Rework optix_stubs.c #174
Merged
Rework optix_stubs.c #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stubs were a copy of optix_stubs.h, but without `inline` so they end up in the binary when compiling them. This change instead includes optix_stubs.h and uses the preprocessor to erase `inline` in the header.
`cc` already sets rustc-link-search and rustc-link-lib after compiling. Since other rerun-if-changed instructions are emitted, specifying build.rs is redudant.
jorge-ortega
force-pushed
the
optix-stubs
branch
from
d2e7484 to
a920608
Compare
|
Learned about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a diff of optix_stubs.c in tree with optix_stubs.h from the SDK showed only whitespace differences and removal of
inlinefrom all the stubs so they end up in the binary when compiling them. This change instead includes optix_stubs.h and uses the preprocessor to eraseinlinein the header.This should make it easier to support newer optix versions without having to update the stubs to match.
Edit: CI won't build this, but this does still build and run the path_tracer example for me on Windows.