password-hash: expose salt generating helper functions #2128
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there's not a way to generate a random salt in the context of MCF password hashes when not using the high-level `PasswordHash::hash_password` API, e.g. for KDF usage, which is to say that for PHC password hashes `phc::Salt::generate` is fine for this purpose since it now provides raw bytes, but password hashes which use MCF don't have access to that type. This is often still documented as using some static value with a comment saying it needs to be unique. Instead we should provide a reusable solution in the rustdoc. These can potentially be replaced with the `crypto_common::Generate` trait and something like a `RecommendedLengthSalt` type after there's a new `getrandom` crate prerelease, but in the meantime these helper functions seem like a reasonable enough stopgap, and can potentially stick around and use the `Generate` trait for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there's not a way to generate a random salt in the context of MCF password hashes when not using the high-level
PasswordHash::hash_passwordAPI, e.g. for KDF usage, which is to say that for PHC password hashesphc::Salt::generateis fine for this purpose since it now provides raw bytes, but password hashes which use MCF don't have access to that type.This is often still documented as using some static value with a comment saying it needs to be unique. Instead we should provide a reusable solution in the rustdoc.
These can potentially be replaced with the
crypto_common::Generatetrait and something like aRecommendedLengthSalttype after there's a newgetrandomcrate prerelease, but in the meantime these helper functions seem like a reasonable enough stopgap, and can potentially stick around and use theGeneratetrait for you.