Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten underlying errors #137

Closed
wants to merge 14 commits into from

Conversation

dangthaison91
Copy link
Contributor

@dangthaison91 dangthaison91 commented Jan 30, 2018

This will resolve #119.

After referring Action's implementation from ReactiveSwift, I decide to add disabledErrors: Observable<Error> and remove ActionError. This will make breaking change but will help end users avoid misunderstand between .errors/.underlyingErrors and .executionErrors from the original proposal. I add ActionDisabledError for better debugging.

What do you think @bobgodwinx

@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Jan 30, 2018

Warnings
⚠️

It looks like code was changed without adding anything to the Changelog. If this is a trivial PR that doesn't need a changelog, add #trivial to the PR title or body.

Generated by 🚫 dangerJS

@mosamer
Copy link
Contributor

mosamer commented Jan 30, 2018

@dangthaison91 as this is a breaking change, would you mind to include it as part of release 4.0, and point this PR to 4.0branch instead of master?

@dangthaison91 dangthaison91 changed the base branch from master to 4.0 January 30, 2018 09:57
@dangthaison91
Copy link
Contributor Author

Thanks for prompting me @mosamer. Changed to branch 4.0.

@dangthaison91 dangthaison91 deleted the flatten-error branch January 30, 2018 10:56
@dangthaison91 dangthaison91 restored the flatten-error branch January 30, 2018 11:09
@dangthaison91 dangthaison91 deleted the flatten-error branch January 31, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants