Flatten error by removing ActionError

[dangthaison91]

I really sorry for a long time not active. This replaces PR for #138 and will resolve #119 (original by @bobgodwinx )

After referring Action's implementation from ReactiveSwift, I decide to add disabledErrors: Observable<Error> and remove ActionError. This will make breaking change but will help end users avoid misunderstand between .errors/.underlyingErrors and .executionErrors from the original proposal. I add ActionDisabledError for better debugging.

What do you think @bobgodwinx

[ashfurrow]

Makes sense – combined with your work on #159, do you think we should target this for the 4.0 branch and release?

[dangthaison91]

@ashfurrow Yeah, this is breaking changes, I will have to add changelog for this before merging it in 4.0.

[ashfurrow]

Makes sense – should we update the 4.0 branch, and then change this PR to point to that branch?

[dangthaison91]

This PR requires the PR #160 to be merged first

[ashfurrow]

Cool. Once this is merged, and 4.0 branch looks good, let's plan to release 4.0. /cc @freak4pc

[dangthaison91]

Should I merge this @ashfurrow ?

[freak4pc]

Hey @dangthaison91 I think you wrongly created this PR with a weird rebase - look at the commits, there are 42 including other people's not just yours.

Please don't merge without a review, since this repo is actually commonly used by people it's critical people will be able to review any breaking changes such as these.

[dangthaison91]

Hmm, should I close this PR and create another one @freak4pc ?

[ashfurrow]

@dangthaison91 that sounds like a good idea – let me know if you run into git trouble.

[freak4pc]

Sure, whatever’s easier for you. Either fix this PR with a rebase or start a new one which might be more straightforward.

…

-- Shai Mishali

On October 22, 2018 at 23:14:58, (Alfred) ***@***.***) wrote: Hmm, should I close this PR and create another one @freak4pc <https://github.com/freak4pc> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#158 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAk7lFFFV54Yz4qRWCQHuqjdwiDn6afKks5unidCgaJpZM4XcztE> .