Skip to content

fix: stop tracking Swift package manager xcworkspace #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

landonr
Copy link

@landonr landonr commented Feb 1, 2021

Fixes #91

RxOptional-SPM.xcodeproj should be generated by CI only and not tracked in the repo.

In order for Carthage to successfully build this project there can't be any xcodeproj's without a project.pbxproj file. The parent RxOptional-SPM.xcodeproj is in the .gitignore however the contents.xcworkspacedata is tracked in this repository so the xcodeproj is still being included.

@freak4pc
Copy link
Member

freak4pc commented Feb 2, 2021

Good fix, but CI is failing, can you fix it?
Thanks

@landonr
Copy link
Author

landonr commented Feb 2, 2021

Good fix, but CI is failing, can you fix it?
Thanks

These failures don't seem specific to my changes so I'm not sure what to do.

  • Lint, build and test / build is failing with a 403 forbidden when its trying to post a comment
  • ci/circleCI: Build Error seems like it has only succeeded once since it was integrated into the project

@ashfurrow
Copy link
Member

I don't even see a Circle config yml file in the repo, and it's failing on master. Let's merge 👍

@ashfurrow ashfurrow merged commit a5eba74 into RxSwiftCommunity:main Feb 2, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @landonr! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow ashfurrow mentioned this pull request Feb 2, 2021
@ashfurrow
Copy link
Member

@landonr thank you for the contribution! If you're looking for another contribution to make, there's #93 🙃 But no pressure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building from Carthage "xcodebuild: error: Unable to read project 'RxOptional-SPM.xcodeproj' from folder"
3 participants