Skip to content

CxOne: support system trust #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CxOne: support system trust #5304

wants to merge 5 commits into from

Conversation

thtri
Copy link
Member

@thtri thtri commented Mar 26, 2025

Description

This integrates CxONE step with the Trust Engine.

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@thtri thtri requested a review from a team as a code owner March 26, 2025 14:28
@thtri thtri marked this pull request as draft March 26, 2025 14:28
Copy link
Member

@hubadr hubadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thtri !
Please see my comment regarding param name, wdyt?

secret: true
resourceRef:
- type: systemTrustSecret
name: cxoneSystemtrustSecretName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the param name should be just cxoneSystemTrustSecret

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubadr apparentlythis is the naming convention in Piper. The postfix "SecretName" is to indicate the name of secret in Vault/Jenkins (and now Trust), see https://github.com/search?q=repo%3ASAP%2Fjenkins-library%20SecretName&type=code

@thtri thtri marked this pull request as ready for review May 20, 2025 06:52
@thtri
Copy link
Member Author

thtri commented May 20, 2025

/it-go

2 similar comments
@thtri
Copy link
Member Author

thtri commented May 20, 2025

/it-go

@thtri
Copy link
Member Author

thtri commented May 20, 2025

/it-go

@CCFenner CCFenner requested a review from jliempt May 20, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants