-
Notifications
You must be signed in to change notification settings - Fork 600
CxOne: support system trust #5304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thtri !
Please see my comment regarding param name, wdyt?
secret: true | ||
resourceRef: | ||
- type: systemTrustSecret | ||
name: cxoneSystemtrustSecretName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the param name should be just cxoneSystemTrustSecret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hubadr apparentlythis is the naming convention in Piper. The postfix "SecretName" is to indicate the name of secret in Vault/Jenkins (and now Trust), see https://github.com/search?q=repo%3ASAP%2Fjenkins-library%20SecretName&type=code
|
/it-go |
2 similar comments
/it-go |
/it-go |
Description
This integrates CxONE step with the Trust Engine.
Checklist