-
Notifications
You must be signed in to change notification settings - Fork 600
Add methods to use the BTP CLI #5305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add methods to use the BTP CLI #5305
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed Authentication.go - will do the rest later.
I gave a little bit of feedback regarding the structure. It would be good to think about the loggedIn boolean again.
…as response format, - additional tests
…n, - enable verbose setting,
|
So this is a fist step, right? And then in another PR you will introduce the corresponding steps that consume this, or put an option into the cf deploy, and other cf steps, to use btp cli instead of cf cli? |
Currently we provide the cf-cli with this docker image: https://github.com/SAP/devops-docker-cf-cli Will you provide a docker image for the btp cli as well, or what is the plan? |
Yes exactly it is the first step. In another PR we will then:
|
Thank you for bringing this up! Currently, our focus is on delivering the essential components in Golang for the BTP CLI. While we aren't providing a Docker image ourselves, team members who utilize these functions or steps will have the ability to create their own custom Docker environment if required. |
Pull Request Description
Objective
This pull request introduces functions to facilitate the use of the BTP CLI. The key functionalities added include:
Key Improvements
CommandBuilder
has been developed to streamline script creation, ensuring efficient command handling.Run
): Enables concurrent task execution without blocking the main process.RunSync
): Incorporates a polling mechanism to verify the success of BTP actions at regular intervals.Synchronous Execution
Currently, BTP actions do not support direct synchronous execution. To address this, a
polling mechanism
has been implemented to continuously check the status of actions, ensuring they are completed successfully.Checklist