Added support for ST_GEOMETRY and ST_POINT (#255)

- Added support for ST_GEOMETRY and ST_POINT by treating them as binary types - ST_GEOMETRY and ST_POINT can only be sent as buffers - Updated integration tests to only run data type tests when the required data format is met - Added integration tests for ST_GEOMETRY and ST_POINT
SAP · Jan 28, 2025 · 58eec9d · 58eec9d
1 parent 3ff9c3e
commit 58eec9d
Show file tree

Hide file tree

Showing 8 changed files with 213 additions and 68 deletions.
diff --git a/lib/protocol/common/DataFormatVersion.js b/lib/protocol/common/DataFormatVersion.js
@@ -19,6 +19,7 @@ module.exports = {
   // deprecated
   EXTENDED_DATE_TIME_SUPPORT: 3,
   LEVEL4: 4,
+  LEVEL5: 5,
   // Maximum data format version supported by this driver
-  MAX_VERSION: 4,
+  MAX_VERSION: 5,
 };
diff --git a/lib/protocol/common/NormalizedTypeCode.js b/lib/protocol/common/NormalizedTypeCode.js
@@ -45,6 +45,8 @@ NormalizedTypeCode[TypeCode.NSTRING] = TypeCode.NSTRING;
 NormalizedTypeCode[TypeCode.BINARY] = TypeCode.BINARY;
 NormalizedTypeCode[TypeCode.VARBINARY] = TypeCode.BINARY;
 NormalizedTypeCode[TypeCode.BSTRING] = TypeCode.BINARY;
+NormalizedTypeCode[TypeCode.ST_GEOMETRY] = TypeCode.BINARY;
+NormalizedTypeCode[TypeCode.ST_POINT] = TypeCode.BINARY;
 // BLob
 NormalizedTypeCode[TypeCode.BLOB] = TypeCode.BLOB;
 NormalizedTypeCode[TypeCode.LOCATOR] = TypeCode.BLOB;

diff --git a/lib/protocol/common/ReadFunction.js b/lib/protocol/common/ReadFunction.js
@@ -70,3 +70,5 @@ ReadFunction[TypeCode.TEXT] = READ_NCLOB;
 ReadFunction[TypeCode.DOUBLE] = READ_DOUBLE;
 ReadFunction[TypeCode.REAL] = READ_FLOAT;
 ReadFunction[TypeCode.DECIMAL] = READ_DECIMAL;
+ReadFunction[TypeCode.ST_GEOMETRY] = READ_BINARY;
+ReadFunction[TypeCode.ST_POINT] = READ_BINARY;
diff --git a/lib/protocol/common/TypeCode.js b/lib/protocol/common/TypeCode.js
@@ -83,5 +83,7 @@ module.exports = {
   CSTIME: 66,
   BLOB_DISK: 71,
   CLOB_DISK: 72,
-  NCLOB_DISK: 73
+  NCLOB_DISK: 73,
+  ST_GEOMETRY: 74,
+  ST_POINT: 75,
 };
diff --git a/lib/protocol/part/ConnectOptions.js b/lib/protocol/part/ConnectOptions.js
@@ -118,6 +118,7 @@ function ConnectOptions() {
   // *  `4` Baseline data type support (SAP HANA SPS 06)
   //        Support for ALPHANUM, TEXT, SHORTTEXT, LONGDATE, SECONDDATE,
   //        DAYDATE, and SECONDTIME.
+  // *  `5` Support for ST_GEOMETRY and ST_POINT
   // TODO: Once implementation and testing for data format version 4 are
   // complete, replace dataFormatVersion and dataFormatVersion2 with the
   // commented-out lines.