feat(ui5-shellbar-search): initial implementation #11398
Conversation
There was a problem hiding this comment.
-
Should we add a sample to the playground? Maybe in the Shellbar, or for sure - add the documentation of the component to the playground.
-
The spec of the Shellbar contains to following acc:
Check with team Pirin if we should do it by default in the ShellBarSearch, or the APP should be able to change it. If the second option is decided (or generally I think this is a good idea) - ariaDescription/ariaDescriptionRef should be enabled on SeachField level as a property. -
Where can I test the new component - there is no test page? At least enrich the ShellBar_evolution.html page.
There was a problem hiding this comment.
I approve the changes, but @dobrinyonkov @MapTo0 please provide a working example with a shellbar search, as the current does not work on mobile and if someone wants to test he has to build his own sample. Also a playground sample should be provided as well.
| @@ -48,7 +48,7 @@ describe("SearchField general interaction", () => { | |||
| cy.get("[ui5-search-field]") | |||
| .shadow() | |||
| .find("input") | |||
| .should("have.attr", "aria-description", SEARCH_FIELD_LABEL.defaultText); | |||
| .should("have.attr", "aria-label", SEARCH_FIELD_LABEL.defaultText); | |||
There was a problem hiding this comment.
The test is for accessibleDescription, please adjust the naming at least.
No description provided.