Set read bit in MCP23S17 and raise exception in TGpioLinuxPin#7
Open
SpaceEEC wants to merge 2 commits intoSAmeis:masterfrom
Open
Set read bit in MCP23S17 and raise exception in TGpioLinuxPin#7SpaceEEC wants to merge 2 commits intoSAmeis:masterfrom
SpaceEEC wants to merge 2 commits intoSAmeis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things I stumbled accross:
MCP23S17
The
r/wbyte was never set, resulting in writing zeros into the register instead of actually reading from it.See the figure from here.
TGpioLinuxPin
When writing to a file via
TGpioLinuxPin.WriteToFilefailed, the created exception would never actually get raised and the whole operations silently fails.