Skip to content

Change CorrectedOpFlash attributed #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Change CorrectedOpFlash attributed #584

wants to merge 2 commits into from

Conversation

asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Sep 29, 2025 •
edited
Loading

Description

Remove CorrectedOpFlash attributes that can be found via slice-correctedopflash assns. It also changes the attributes to reflect each of the corrections separately.

Merging this PR solves SBNSoftware/sbnanaobj#160 .

This PR is to be merged with
SBNSoftware/sbnanaobj#162
SBNSoftware/sbnobj#147

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@asanchezcastillo asanchezcastillo self-assigned this Sep 29, 2025
@asanchezcastillo asanchezcastillo added the enhancement New feature or request label Sep 29, 2025
@asanchezcastillo asanchezcastillo marked this pull request as ready for review September 29, 2025 17:02
This was referenced Sep 29, 2025
Open
Open
Open
@kjplows kjplows moved this to Open pull requests in SBN software development Oct 2, 2025
@kjplows kjplows requested a review from JosiePaton October 2, 2025 13:50
gputnam
gputnam reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@gputnam gputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on the sbnanaobj PR.

@kjplows kjplows moved this from Open pull requests to Partially reviewed in SBN software development Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gputnam gputnam gputnam left review comments

@JosiePaton JosiePaton JosiePaton approved these changes

@linyan-w linyan-w linyan-w approved these changes

@PetrilloAtWork PetrilloAtWork Awaiting requested review from PetrilloAtWork

Assignees

@asanchezcastillo asanchezcastillo

Labels

enhancement New feature or request

Projects

SBN software development
Status: Partially reviewed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asanchezcastillo @gputnam @JosiePaton @linyan-w @kjplows