Skip to content

Update CorrectedOpFlash attributes #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update CorrectedOpFlash attributes #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
294c82f
Update CorrectedOpFlash attributes
asanchezcastillo Sep 26, 2025
004d798
Change time units from ns to us
asanchezcastillo Oct 1, 2025
65c1c0b
Change angle unit from us to deg
asanchezcastillo Oct 1, 2025
25e4ade
Merge branch 'develop' into feature/acastill_lightpropagationfixes
kjplows Oct 16, 2025
28493be
Merge branch 'develop' into feature/acastill_lightpropagationfixes
kjplows Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions sbnobj/Common/Reco/CorrectedOpFlashTiming.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,12 @@ namespace sbn {

/// @name Corrected OpFlash Times
/// @{
float OpFlashT0 { fDefault }; ///< | OpFlash Time wrt RWM time | (ns)
float UpstreamTime_lightonly { fDefault }; ///< | Nu upstream wall time reconstructed using light only | (ns)
float UpstreamTime_tpczcorr { fDefault }; ///< | Nu upstream wall time reconstructed using light and Z from tpc vertex | (ns)
float UpstreamTime_propcorr_tpczcorr { fDefault }; ///< | Nu upstream wall time reconstructed using light propagation correction from tpc information and z correction from tpc vertex | (ns)

/// @}

/// @name Data members related to the slice-flash match
/// @{
float FMScore { fDefault }; ///< | OpFlash Time wrt RWM time | (ns)

float OpFlashT0 { fDefault }; ///< | OpFlash Time wrt RWM time | (us)
float NuToFLight { fDefault }; ///< | Nu ToF using light only | (us)
float NuToFCharge { fDefault }; ///< | Nu ToF Z from tpc vertex | (us)
Comment on lines +27 to +28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation, could you spell "time of flight" out? It may save some time to unaccustomed readers.

Suggested change
float NuToFLight { fDefault }; ///< | Nu ToF using light only | (us)
float NuToFCharge { fDefault }; ///< | Nu ToF Z from tpc vertex | (us)
float NuToFLight { fDefault }; ///< | Nu time of flight using light only | (us)
float NuToFCharge { fDefault }; ///< | Nu time of flight using Z from TPC vertex | (us)

float OpFlashT0Corrected { fDefault }; ///< | OpFlash Time wrt RWM time after light propagation corrections | (us)
/// @}

/// @name Data members related to the slice match
/// @{
float SliceNuScore { fDefault }; ///< | OpFlash Time wrt RWM time | (ns)

/// @}


};
}

Expand Down
2 changes: 1 addition & 1 deletion sbnobj/Common/Reco/TPCPMTBarycenterMatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ namespace sbn {
float deltaY { fDefault }; ///< | Matched flash Y center - charge Y center | (cm)
float deltaZ { fDefault }; ///< | Matched flash Z center - charge Z center | (cm)
float radius { fDefault }; ///< Hypotenuse of DeltaY and DeltaZ (cm)
float angle { fDefault }; ///< | Angle between charge PCA and light PCA | (us)
float angle { fDefault }; ///< | Angle between charge PCA and light PCA | (deg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been radians...

float chi2 { fDefault }; ///< | Chi2 to be minimised when matching flash to slice | (dimensionless)
float score { fDefault }; ///< | Score to be maximised when matching flash to slice | (dimensionless)
float deltaT { fDefault }; ///< | Matched flash time - anab::T0 | when available (us)
Expand Down
3 changes: 2 additions & 1 deletion sbnobj/Common/Reco/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,8 @@

<class name="std::vector<geo::PlaneID>"/>

<class name="sbn::CorrectedOpFlashTiming" ClassVersion="15">
<class name="sbn::CorrectedOpFlashTiming" ClassVersion="16">
<version ClassVersion="16" checksum="1734226620"/>
<version ClassVersion="15" checksum="2401924061"/>
<version ClassVersion="14" checksum="2635318722"/>
<version ClassVersion="13" checksum="328467396"/>
Expand Down