Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variables.PackageVariable with bool default string #4703

Merged
merged 2 commits into from
Mar 29, 2025

Conversation

dekeonus
Copy link
Contributor

when passed a 'true' string on the command line actually test default value against both ENABLE_STRINGS and DISABLE_STRINGS

Closes: #4702

See-Also: https://bugs.gentoo.org/950584

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
  • I have updated the appropriate documentation

when passed a 'true' string on the command line actually test default
value against both ENABLE_STRINGS and DISABLE_STRINGS

Closes: SCons#4702

See-Also: https://bugs.gentoo.org/950584

Signed-off-by: Bill Prendergast <[email protected]>
@bdbaddog
Copy link
Contributor

Please also add a blurb to RELEASE.txt

@bdbaddog bdbaddog merged commit be6c181 into SCons:master Mar 29, 2025
@mwichmann mwichmann added this to the NextRelease milestone Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Variables/PackageVariable.py only compares *default* against ENABLE_STRINGS
3 participants