-
-
Notifications
You must be signed in to change notification settings - Fork 338
[WIP] Added --cache-dir flag and test. #4778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bdbaddog
wants to merge
12
commits into
SCons:master
Choose a base branch
from
bdbaddog:feature/cachedir_cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+573
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 5 of the series. Signed-off-by: Mats Wichmann <[email protected]>
Both functions have equivalence tables between option names they can use and the corresponding command-line options. The cli option names are now clickable to be able to jump to the actual descriptions (there are no option behavior descriptions in GetOption or SetOption). A little bit of wording tweak as well, limited to these two functions. Signed-off-by: Mats Wichmann <[email protected]>
…cachdir-opt branch
index 98725d5ed..dbc60c415 100644
--- a/doc/man/scons.xml
+++ b/doc/man/scons.xml
@@ -708,6 +708,20 @@ derived-file cache specified by &f-link-CacheDir;.</para>
</listitem>
</varlistentry>
+ <varlistentry id="opt-cache-dir">
+ <term>-<option>-cache-dir=<replaceable>cachedir</replaceable></option></term>
+ <listitem>
+<para>Enable derived-file caching globally, using
+<replaceable>cachedir</replaceable> as the cache directory.
+An individual &consenv; may still specify a different
+cache directory by calling &f-link-env-CacheDir;.
+</para>
+<para><emphasis>Added in version NEXT_RELEASE.</emphasis></para>
+ </listitem>
+ </varlistentry>
+
+ <varlistentry>
+
<varlistentry id="opt-cache-disable">
<term>
<option>--cache-disable</option>,Questions:
|
manpage: make clickable links for Get/SetOption
More Builder Method manpage updates
…cachdir-opt branch
… feature/cachedir_cli
Tweak: intermediate directories are now made so the temporary cachedir creation is less likely to fail. Tweak: if debug output is selected and sent to a file, the file is now opened in append mode. This fixes a problem of lost output if multiple cachedirs are used in one run (presumably rare except for testing scenarios), but isn't an ideal solution for the issue. Signed-off-by: Mats Wichmann <[email protected]>
Add manpage entry for --cache-dir + tweaks
|
A checklist of things to work out. This was supposed to be a simple change (cough, cough).
Possible test for multiple global cache specifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test copied from @mwichmann 's feature/cachdir-opt branch
doc and readme/etc forthcoming
Copied from @mwichmann comment below:
A checklist of things to work out. This was supposed to be a simple change (cough, cough).
cache1crreated in both top dir and insrc.--cache-debugfile is an only-one thing; it looks like the logic can open this several times, which isn't great. It was originally opened in write mode, which meant a second open clobbered info from the first. For now, it's being opened in append more to not lost logged data. Possibly debug info should store in class attributes, rather than instance?Possible test for multiple global cache specifications
cachedir-cli.tar.gz
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).