-
Notifications
You must be signed in to change notification settings - Fork 11
Adding Multiperiod Blending Problem to GDPlib #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arshb11
wants to merge
21
commits into
SECQUOIA:main
Choose a base branch
from
arshb11:mpbp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
45e63b7
Created mpbp folder and added json instances
arshb11 6a877a4
Added and working model
arshb11 9b35275
Added README
arshb11 de38c8d
Update README.md
arshb11 1db3e13
Added documentation for multiperiod_blending model
arshb11 833303f
update readme
arshb11 357475a
Merge branch 'mpbp' of https://github.com/arshb11/gdplib into mpbp
arshb11 fe7f8a7
Update __init__.py
arshb11 4d1b75b
Adding convert_json_to_dict to multiperiod __init__
arshb11 e4be0b6
Merge branch 'mpbp' of https://github.com/arshb11/gdplib into mpbp
arshb11 a423ce7
Added default data input to build_model(). This calls mpbp_6.json
arshb11 0241bd9
multiperiod_blending.py
arshb11 430cdea
Update README.md
arshb11 970f4c3
Update multiperiod_blending.py
arshb11 6fb37ef
Added ovalle-bhatia citation to multiperiod_blending.py file.
arshb11 bcff2eb
Merge branch 'mpbp' of https://github.com/arshb11/gdplib into mpbp
arshb11 efe3df1
removed TODOs in multiperiod_blending
arshb11 4adabb3
Added solver and instance selection as a command line argument.
arshb11 0d9c02b
Correct multiperiod/init
arshb11 d20e2a5
Added multiperiod_blending to tests
arshb11 962e7b4
Applied black
arshb11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Multiperiod Blending Problem | ||
| This model is a GDP formulation for the Multiperiod Blending Problem. This model was originally formulated by Lotero et. al. and Ovalle et. al. developed 60 test instances which have can be found in `instances_json/`. If you want to learn more about the problem and instances please see the following github repo: https://github.com/arshb11/mpbp-instances. | ||
|
|
||
| If you decide to use these instances or model, please cite the following papers: | ||
|
|
||
| > Ovalle, D., Bhatia, A., Laird, C. D., & Grossmann, I. E. (2026). A logic-based decomposition for the global optimization of the multiperiod blending problem using symmetry-breaking cuts. Industrial & Engineering Chemistry Research, 65(7), 3981–3998. https://doi.org/10.1021/acs.iecr.5c02853 | ||
|
arshb11 marked this conversation as resolved.
Outdated
|
||
| > | ||
| > Lotero, I., Trespalacios, F., Grossmann, I. E., Papageorgiou, D. J., & Cheon, M.-S. (2016). An MILP-MINLP decomposition method for the global optimization of a source based model of the multiperiod blending problem. Computers & Chemical Engineering, 87, 13–35. https://doi.org/10.1016/j.compchemeng.2015.12.017 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from .multiperiod_blending import build_model | ||
|
arshb11 marked this conversation as resolved.
Outdated
arshb11 marked this conversation as resolved.
Outdated
|
||
|
|
||
| __all__ = ["build_model"] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that this is added here. One thing to be aware of: the test module lists in
tests/test_comprehensive_coverage.py(ALL_GDPLIB_MODULES),tests/test_module_imports.py(GDPLIB_MODULES), andtests/test_model_structure.py(GDPLIB_MODULES) are maintained manually. You will need to add"multiperiod_blending"to each of those lists for the PR's CI checks to cover this new module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. I have added
multiperiod_blendingto the test modules. @bernalde could you just check if it has been added correctly and the tests are running fine? They were working on my end but I had to install some packages like scipy, openpyxl, pint.