Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EDA examples csv data when creating records #45

Merged
merged 25 commits into from
Apr 10, 2022

Conversation

umeditor
Copy link
Contributor

No description provided.

@umeditor umeditor changed the title Add EDA Contact example Update EDA examples csv data when creating records Oct 21, 2021
@umeditor
Copy link
Contributor Author

Would be good to have someone try these recipes in a clean EDA scratch org to make sure they work:

  • cci task run generate_and_load_from_yaml -o generator_yaml snowfakery_samples/EDA/Contact_EDA.recipe.yml --org qa
  • cci task run generate_and_load_from_yaml -o generator_yaml snowfakery_samples/EDA/Account_EDA.recipe.yml --org qa
  • cci task run generate_and_load_from_yaml -o generator_yaml snowfakery_samples/EDA/Affiliation_EDA.recipe.yml --org qa
  • cci task run generate_and_load_from_yaml -o generator_yaml snowfakery_samples/EDA/ContactAffiliation_EDA.recipe.yml --org qa

Copy link
Contributor

@acrosman acrosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing so much with these. This is great progress, and pulls the big recipe apart into more meaningful pieces. There are a couple issues that concern me that I'd like to address or discuss before merging.

@@ -0,0 +1,201 @@
name
American University
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we lack a good solve for this today, I am concerned about using real names here. We have plans for a new faker provider to solve this more effectively in the future with generated names. I think I'd rather a short list of made up names than real.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to use the new faker_edu provider to generate names.

@allisonletts allisonletts added the pkg-eda EDA managed package issues that don't require any add-ons like Success Hub or Admissions Connect label Feb 21, 2022
@allisonletts allisonletts removed their request for review February 27, 2022 03:41
@allisonletts
Copy link
Contributor

@umeditor and @acrosman I'd love to move the fake data in here over to faker_edu now that it's a real thing. @umeditor can you list your source in the commit somewhere, or in a readme in the directory?

@acrosman
Copy link
Contributor

acrosman commented Mar 8, 2022

Love seeing EDU Faker in use! But we should probably add a note/instructions about how to get the plugin into the instructions.

@samanthashain
Copy link
Contributor

@umeditor @allisonletts @acrosman it looks like this is very nearly ready to go. do you need any support to complete the documentation on accessing EDU faker and approving this PR?

@acrosman
Copy link
Contributor

acrosman commented Apr 6, 2022

The only hold up is that I haven't had a chance to validate the instructions and test the current recipe version. I suspect we're good to go once we do those things.

@acrosman
Copy link
Contributor

Thanks for all the work that went into this. It caused me to notice that our faker providers could use better instructions for how to install them to run with Snowfakery's pipx environment, but that's not a concern for this issue (or even this project). Opened SFDO-Community-Sprints/Snowfakery-Edu#19 and SFDO-Community-Sprints/Snowfakery-Nonprofit#9 to resolve those.

@acrosman acrosman merged commit 24240c4 into SFDO-Community-Sprints:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg-eda EDA managed package issues that don't require any add-ons like Success Hub or Admissions Connect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants