-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EDA examples csv data when creating records #45
Update EDA examples csv data when creating records #45
Conversation
Remove installing Snowfakery as it is now included with cci.
…Recipe-Templates into update-eda-examples
Would be good to have someone try these recipes in a clean EDA scratch org to make sure they work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing so much with these. This is great progress, and pulls the big recipe apart into more meaningful pieces. There are a couple issues that concern me that I'd like to address or discuss before merging.
@@ -0,0 +1,201 @@ | |||
name | |||
American University |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we lack a good solve for this today, I am concerned about using real names here. We have plans for a new faker provider to solve this more effectively in the future with generated names. I think I'd rather a short list of made up names than real.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to use the new faker_edu provider to generate names.
Love seeing EDU Faker in use! But we should probably add a note/instructions about how to get the plugin into the instructions. |
@umeditor @allisonletts @acrosman it looks like this is very nearly ready to go. do you need any support to complete the documentation on accessing EDU faker and approving this PR? |
The only hold up is that I haven't had a chance to validate the instructions and test the current recipe version. I suspect we're good to go once we do those things. |
Thanks for all the work that went into this. It caused me to notice that our faker providers could use better instructions for how to install them to run with Snowfakery's pipx environment, but that's not a concern for this issue (or even this project). Opened SFDO-Community-Sprints/Snowfakery-Edu#19 and SFDO-Community-Sprints/Snowfakery-Nonprofit#9 to resolve those. |
No description provided.