Skip to content

Add cost stamps #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add cost stamps #1745

wants to merge 14 commits into from

Conversation

dmwever
Copy link
Contributor

@dmwever dmwever commented Jan 22, 2025

fixes #1676.

jere8184
jere8184 suggested changes Jan 22, 2025
View reviewed changes
@dmwever dmwever requested a review from jere8184 January 23, 2025 22:17
jere8184
jere8184 reviewed Jan 23, 2025
View reviewed changes
jere8184
jere8184 reviewed Jan 23, 2025
View reviewed changes
jere8184
jere8184 suggested changes Jan 24, 2025
View reviewed changes
heinezen
heinezen requested changes Jan 25, 2025
View reviewed changes
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far.

In addition to the fixes to the comments I made, you should also add unit tests for stamping and unstamping the cost field in tests.cpp.

@heinezen heinezen added nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code area: simulation Involved in the game mechanics and simulation labels May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen requested changes

+1 more reviewer

@jere8184 jere8184 jere8184 requested changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area: simulation Involved in the game mechanics and simulation lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before
Projects
openage game simulation
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cost stamps (pathfinder)
3 participants
@dmwever @heinezen @jere8184