Add the Kroupa IMF to the BPASS SED#259
Merged
petercamps merged 17 commits intoSKIRT:masterfrom Dec 18, 2025
Merged
Conversation
**Description** Enable to read dust properties from from Draine & Li (2007) individually **Motivation** SKIRT could not handle individual dust propeties from Draine & Li (2007) model, but could use those from the Draine & Li (2001) model. **Tests** No, but the original data was already used for "DraineLiDustMix".
…aphite from Draine&Li (2007) model.)
…eGasMix. Incorporate non-LTE line radiative transfer calculations for HCN, N+, O, and O++. Additionally, we have updated the collisional transition data for HCO+. The relevant data is sourced from LAMDA (https://home.strw.leidenuniv.nl/~moldata/).
Introduces the IonizedOxygen (O+) species to NonLTELineGasMix, including its enumeration, documentation, and collisional partners. This enables modeling of O+ with electrons as the collisional partner and updates relevant class comments and enum definitions.
Enhanced the LU decomposition solver to perform partial pivoting more flexibly, throw detailed errors for singular or nearly singular matrices, and check for non-finite solutions. Expanded logging and user guidance for inaccurate Gaussian line profile integrals, including suggestions for wavelength coverage and velocity domain settings.
* Update BPASS SED family to incorporate the Kuropa IMF. * Adjust the expected resource pack version
…profile" This reverts commit 29b21aa.
Contributor
|
Kosei,
Thanks for this. However, I cannot access/download the stab files. After clicking the link, I get an error message from the Sharepoint server implying that there are no files in that place.

There may also be an issue with access rights because I have multiple email addresses and microsoft accounts; so perhaps I’m not using the correct credentials.
Can you check that the files are there? Alternatively, can you use WeTransfer or SwissTransfer to send them to me?
Peter
…___________________
Peter Camps
***@***.***
Astronomical Observatory, Ghent University
Krijgslaan 281 - S9, B-9000 Gent
Op 17 dec 2025, om 18:11 heeft Kosei Matsumoto ***@***.***> het volgende geschreven:
Description
I have implemented the Kroupa IMF in the BPASS SED models.
Motivation
For mock observations of the MEGATRON cosmological simulation, BPASS SEDs with a Kroupa IMF are required.
Tests
I verified that the output spectra are correct.
** new stab data**
The data can be download from this link:
https://ugentbe-my.sharepoint.com/:f:/g/personal/kosei_matsumoto_ugent_be/IgDVnEA7x7_FQIZNZWlkgu_bAeqEzlkXnumKn1lu59ZbbAM?e=SWJhyb
You can view, comment on, or merge this pull request online at:
#259
Commit Summary
0f41d9c <0f41d9c> Enable to read dust properties from Draine & Li (2007)
3795dbd <3795dbd> enable to use individual optical properties of PAHs, Silicate, and graphite from Draine&Li (2007) model.)
4c1b1ab <4c1b1ab> Merge branch 'SKIRT:master' into DraineLi2007DustModels
5864620 <5864620> Add HCN, N+, O, and O++ and update the database of HCO+ for NonLTELineGasMix.
5c51bfc <5c51bfc> Add support for ionized oxygen (O+) species
29b21aa <29b21aa> Improve error handling and logging in LU solver and Gaussian profile
e3268de <e3268de> Merge branch 'SKIRT:master' into DraineLi2007DustModels
968a83b <968a83b> Update BPASS SED family with the Kuropa IMF
a4b72f3 <a4b72f3> revert 0f41d9c
07ea5a4 <07ea5a4> revert 3795dbd
a478453 <a478453> revert 5864620 and 5c51bfc
afbc5db <afbc5db> Revert "Improve error handling and logging in LU solver and Gaussian profile"
63435ce <63435ce> readd formyl in NonLTE
File Changes (4 files <https://github.com/SKIRT/SKIRT9/pull/259/files>)
M SKIRT/core/BpassSED.cpp <https://github.com/SKIRT/SKIRT9/pull/259/files#diff-dd12858816912f362cba4fd05e6471fe4679e23a096b444d44dd9d98258320ad> (37)
M SKIRT/core/BpassSED.hpp <https://github.com/SKIRT/SKIRT9/pull/259/files#diff-efe946f9d7057969dd25eb5992d72a2defd91e592b6669dc43e5029ce1123756> (22)
M SKIRT/core/BpassSEDFamily.cpp <https://github.com/SKIRT/SKIRT9/pull/259/files#diff-8ab19ea091641015a76d0d922d6f70f6717e87cc9ef004cc7471131f1d436bdb> (2)
M SKIRT/core/BpassSEDFamily.hpp <https://github.com/SKIRT/SKIRT9/pull/259/files#diff-5b58d16dea3920fb29670fa5675959e99dfd0854124c23070e36d6fed535cd8d> (9)
Patch Links:
https://github.com/SKIRT/SKIRT9/pull/259.patch
https://github.com/SKIRT/SKIRT9/pull/259.diff
—
Reply to this email directly, view it on GitHub <#259>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB43IE6TPXGTLBAFXRJTHLL4CGFDTAVCNFSM6AAAAACPKYVBL2VHI2DSMVQWIX3LMV43ASLTON2WKOZTG4ZTSNZTG4YTGOA>.
You are receiving this because you are subscribed to this thread.
|
Contributor
Author
|
Thank you for your response. Is it also possible to check this Share point, again? if you can access the Share point, it might be helpful to upload some other data in near future, since there is no limitation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have implemented the Kroupa IMF in the BPASS SED models.
Motivation
For mock observations of the MEGATRON cosmological simulation, BPASS SEDs with a Kroupa IMF are required.
Tests
I verified that the output spectra are correct.
** new stab data**
The data can be download from this link:
https://ugentbe-my.sharepoint.com/:f:/g/personal/kosei_matsumoto_ugent_be/IgDVnEA7x7_FQIZNZWlkgu_bAeqEzlkXnumKn1lu59ZbbAM?e=SWJhyb