✨feat: 세미나 7주차 실습 과제 완료 #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlaud2000
approved these changes
May 28, 2025
Member
wlaud2000
left a comment
wlaud2000
left a comment
There was a problem hiding this comment.
구현은 잘 해주신것 같은데 yml에서 키를 못찾았다고 오류가 뜨는건 이따가 한번 같이 봐야할 것 같습니다! 고생하셨습니다!
| @GetMapping("/air/seoul") | ||
| public ResponseEntity<AirKoreaResponse> getSeoulAir() { | ||
| AirKoreaResponse result = airKoreaService.getAirQuality("서울"); | ||
| return ResponseEntity.ok(result); |
|
|
||
| import java.util.List; | ||
|
|
||
| @Data |
Member
There was a problem hiding this comment.
Data 어노테이션의 사용을 지양해주세요!
참고자료 -
https://velog.io/@penrose_15/Data%EC%97%90-%EB%8C%80%ED%95%9C-%EA%B3%A0%EC%B0%B0
Comment on lines
+33
to
+34
| // RefreshToken 저장 (DB에 갱신) | ||
| tokenRepository.save(new Token(member.getEmail(), refreshToken)); |
Member
There was a problem hiding this comment.
refresh Token을 Redis에 저장하고있는데 RDB에 또 저장 할 필요는 없어보입니다!
| host: localhost | ||
| port: 6379 | ||
| airkorea: | ||
| service-key: gC3iWj2EfzQMMLVRORT5ecvxJ370Y/4gR8N3A9miRKeMJi0SiYNqLTVyVesGQqGIREPBEB3m3CbL5TroUDTiHA== |
Member
There was a problem hiding this comment.
yml을 github에 공개 시 api key를 공개하는건 위험합니다 환경변수로 설정해주시거나 gitignore 처리 해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️Issue Number
📌 개요
-Redis – Refresh Token 관리
-Open API
🔁 변경 사항
📸 스크린샷
👀 기타 더 이야기해볼 점