Skip to content

Conversation

@hyoinYang
Copy link
Collaborator

πŸ“ PR νƒ€μž… (ν•˜λ‚˜ 이상 선택)

  • κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • μ˜μ‘΄μ„±, ν™˜κ²½ λ³€μˆ˜, λΉŒλ“œ κ΄€λ ¨ μ½”λ“œ μ—…λ°μ΄νŠΈ
  • 기타 μ‚¬μ†Œν•œ μˆ˜μ •

❗️ κ΄€λ ¨ 이슈 링크

Close #89

πŸ“Œ κ°œμš”

  • ch8 μ‹€μŠ΅μΈ OAuth2 κ΅¬ν˜„

πŸ” λ³€κ²½ 사항

OAuth2ServiceImpl ν•¨μˆ˜ κ°œμ„ , id λŒ€μ‹  email 적용 -> c2ee5bc

πŸ“Έ μŠ€ν¬λ¦°μƒ·

πŸ‘€ 기타 더 이야기해볼 점

μ›Œν¬λΆμ—μ„  토큰 λ°œν–‰ 전에 member을 μ €μž₯ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. 그럼 νšŒμ›κ°€μž… λ’€ λ˜λ‹€μ‹œ λ‘œκ·ΈμΈμ„ ν•΄μ•Ό ν•˜λŠ” 게 번거둜운 것 같은데, λŒ€λΆ€λΆ„ μ΄λ ‡κ²Œ νšŒμ›κ°€μž… 뒀에 λ‹€μ‹œ λ‘œκ·ΈμΈν•˜λŠ” 방식을 μ‚¬μš©ν•˜λŠ”μ§€ κΆκΈˆν•©λ‹ˆλ‹€.
μ œκ°€ μž„μ˜λ‘œ μˆ˜μ •ν–ˆμ—ˆλŠ”λ°, 기쑴에 있던 MemberService에선 νšŒμ›κ°€μž… λ’€ λ‘œκ·ΈμΈμ„ ν•΄μ•Όλ§Œ 토큰을 λ°œν–‰ν•˜λŠ” ν˜•μ‹μ΄κΈ°μ— λ³€κ²½μ‚¬ν•­μ—λŠ” λ°˜μ˜ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€. (λ¨Έμ§€ν•œ λ’€, λ‹€μŒ μ›Œν¬λΆ μˆ˜ν–‰ 전에 μˆ˜μ •ν•˜κ³  μ»€λ°‹ν•˜κ² μŠ΅λ‹ˆλ‹€)

βœ… 체크 리슀트

  • PR ν…œν”Œλ¦Ώμ— λ§žμΆ”μ–΄ μž‘μ„±ν–ˆμ–΄μš”.
  • λ³€κ²½ λ‚΄μš©μ— λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό μ§„ν–‰ν–ˆμ–΄μš”.
  • ν”„λ‘œκ·Έλž¨μ΄ μ •μƒμ μœΌλ‘œ λ™μž‘ν•΄μš”.
  • PR에 μ μ ˆν•œ 라벨을 μ„ νƒν–ˆμ–΄μš”.
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ‚­μ œν–ˆμ–΄μš”.

@hyoinYang hyoinYang requested a review from Properks May 13, 2025 07:36
@hyoinYang hyoinYang self-assigned this May 13, 2025
@hyoinYang hyoinYang added the ✨feature κΈ°λŠ₯ μΆ”κ°€ label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feature κΈ°λŠ₯ μΆ”κ°€

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants