replace deprecated usage of setup.py #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zip_safe: see https://setuptools.pypa.io/en/latest/deprecated/zip_safe.html test_suite: see https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-test-suite and note this is not needed by pytest Additionally, .glb files are no longer included in snewpy since v1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346.
Python packaging documentation explicitly warns that commands like
python setup.py sdist bdist_wheelare deprecated and “MUST NOT be run anymore”.This PR modernizes our publishing workflow as recommended there. The
buildmodule ensures more reproducible builds by requiring build dependencies to be explicitly declared (in apyproject.tomlfile) and building the project in an isolated virtual environment. As a nice side effect, this PR also cleans up some helper code which was no longer necessary.