-
Notifications
You must be signed in to change notification settings - Fork 0
Code refactoring for the repo pruning pass. #113
Conversation
We could really use an explanation of what's being proposed (what it being changed and why). I know that this information exists elsewhere, but it would be kind to future code archaeologists to include it here. |
This commit is a code refactoring for the repo pruning pass. In the master branch, two kinds of pruning exist in the pass: the repository level and the module level.
However, they are handled in a single function. This commit is just a code factoring to make two kinds of pruning more obvious and noticeable. |
998e592
to
99f6251
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes much more sense now. Relatively minor comments.
99f6251
to
6db1b31
Compare
@paulhuggett , Are you happy with the change? |
747bd9b
to
d678e09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d678e09
to
af5c423
Compare
This is a spin-off pull request from #109 .