Skip to content

Conversation

@nitram509
Copy link

@nitram509 nitram509 commented Oct 30, 2024

This PR supersedes
#63 "Implement DecodeChains function that accepts multiple key bags"
and #64 "refactor tests to use static files, to ease development"
Resolves #62

It contains three main changes/enhancements

  • new function DecodeChains() supports decoding multiple safebags with private keys
  • refactored tests to use embed feature of go to ease test file creation and usage
  • splitting source files to separate pfx encoder and decoder logic, makes code more readable
  • fixes a bug in Implement DecodeChains function that accepts multiple key bags #63, when CA certificate chains contained duplicate certificates
  • improved documentation for users, to better guide, when to use what function (e.g. DecodeChain vs. DecodeTruststore)

Any feedback welcome.

@nitram509
Copy link
Author

Hi @AGWA may I ask for a review, please?

@marsskop
Copy link

marsskop commented Feb 7, 2025

Tests pass now:

$ go test                                                          
PASS
ok      software.sslmate.com/src/go-pkcs12      0.842s

@nitram509
Copy link
Author

Hi @AGWA , @tony2001 , @aramase may I ask, if you could review this PR, please - or ow can I support further?

@nitram509
Copy link
Author

Hi @AGWA , @tony2001 , @aramase may I ask, if you could review this PR, please - or ow can I support further?

Hi @AGWA, may I ask if there's a chance you could have some time to review, merge and release this PR, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement DecodeChains function that accepts multiple key bags

2 participants