test rewrite: legacy intg test_pam_responder.py - remaining batch - #9028
Open
danlavu wants to merge 4 commits into
Open
test rewrite: legacy intg test_pam_responder.py - remaining batch#9028danlavu wants to merge 4 commits into
danlavu wants to merge 4 commits into
Conversation
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py - test_smartcard__login_fails_when_wrong_pin_is_entered - test_smartcard__login_fails_when_card_is_not_mapped - test_smartcard__cert_auth_limited_to_allowed_pam_services - test_smartcard__login_succeeds_when_cert_auth_required - test_smartcard__login_fails_when_cert_auth_required_without_card - test_authentication__custom_password_prompt_is_shown_at_login Peeling out the reviewed test cases into it's own PR, from SSSD#8873 Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Claude Sonnet 4.6
Covered by the newly ported system tests: - test_sc_auth_wrong_pin -> test_smartcard__login_fails_when_wrong_pin_is_entered - test_try_sc_auth, test_try_sc_auth_no_map -> test_smartcard__login_fails_when_card_is_not_mapped - test_sc_proxy_password_fallback, test_sc_proxy_no_password_fallback -> test_smartcard__certificate_authentication_is_limited_to_allowed_pam_services - test_require_sc_auth -> test_smartcard__login_succeeds_when_cert_auth_required - test_require_sc_auth_no_cert -> test_smartcard__login_fails_when_cert_auth_required_without_card - test_password_prompting_config_global, test_password_prompting_config_srv -> test_authentication__custom_password_prompt_is_shown_at_login Already covered - test_preauth_indicator - implementation-detail file check, no functional proof; smart-card availability is already proven functionally by test_smartcard.py - test_sc_auth - duplicate of test_smartcard__su_as_local_user - test_sc_auth_two - duplicate; multi-cert selection already exercised by test_smartcard__two_tokens_match_on_both - test_krb5_auth - basic Kerberos login success/negative-password coverage already exists via client.sssd.common.krb5_auth() in test_authentication.py / test_ldap_krb5.py Remaining cases - test_try_sc_auth_root - test_sc_auth_missing_name - test_sc_auth_name_format = test_krb5_auth_domains Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Claude Sonnet 4.6
Rewrite the remaining sssd/src/tests/intg/test_pam_responder.py cases to test_smartcard.py, test_authentication.py - test_try_sc_auth_root -> test_smartcard__try_cert_auth_never_used_for_root - test_sc_auth_missing_name, test_sc_auth_missing_name_whitespace -> test_smartcard__certificate_owner_resolved_when_username_is_missing - test_sc_auth_name_format -> test_smartcard__certificate_owner_resolved_with_full_name_format - test_sc_auth_two_missing_name -> test_smartcard__certificate_owner_resolved_with_two_tokens_and_missing_name - test_krb5_auth_domains -> test_authentication__pam_sss_domains_skips_non_matching_krb5_domains Peeling out the reviewed test cases into it's own PR, from SSSD#8873 Co-authored-by: Cursor <cursoragent@cursor.com> Model used: Claude Sonnet 5
danlavu
force-pushed
the
rewrite-test_pam_responder.py2
branch
from
July 31, 2026 06:05
222f600 to
f6daee9
Compare
danlavu
requested review from
krishnavema and
thalman
and removed request for
thalman
July 31, 2026 06:06
Contributor
Author
|
This PR was branched from #9004 , it will contain extra commits until 9004 is merged. Look at the specific commit or wait until 9004 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the remaining sssd/src/tests/intg/test_pam_responder.py cases to
test_smartcard.py, test_authentication.py
Peeling out the reviewed test cases into it's own PR, from
#8873
Requires the following framework change
SSSD/sssd-test-framework#262
Co-authored-by: Cursor cursoragent@cursor.com
Model used: Claude Sonnet 5