Open
Conversation
Only minor changes regarding the class definition and string splitting.
Only print statements needed to be updated
Update print statements. Line 1075 looks like there may be a logical error resulting from indentation.
rmorgan10
commented
Sep 28, 2021
| verbose=2 | ||
| matchSortedStdwithObsCats(stdfile,objfile,outfile,stdracol,stddeccol,obsracol,obsdeccol,matchTolArcsec,verbose) | ||
|
|
||
| # Rob Morgan (9/28/21) This indentation seems troublesome. Someone should take a look. |
Contributor
Author
There was a problem hiding this comment.
@kherner This indentation issue I mentioned was also present in the "-old" version of the BLISS script.
Collaborator
There was a problem hiding this comment.
I have to remind myself of the logic here.
Updated print statement syntax
Contributor
Author
|
I accidentally did the changes for QC_check.py on the master branch in commit 7683096, but those changes should be reviewed too. |
Only changed one print statement.
just updated one print statement
Print statements, configparser, and integer division updates
Included chages for configparser, integer division, and one print statement that was missed the first time
Updated print statements, integer division, and configparser.
Update easy_install, integer division, print statements, and configparser.
Print statements, configparser, and integer division changes
Contributor
Author
|
Just to summarize the whole PR, the Python 2 elements I found were:
|
kherner
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several scripts to Python 3 syntax.