Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srmode refactoring #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PeterPitterling
Copy link

@PeterPitterling PeterPitterling commented Jan 25, 2024

SAPHanaController - check_for_primary
move sleep 20 to case error handling before repeated execution
get rid of redundant coding by moving 2 lines within for loop

SAPHanaTopology
check_for_primary - remove redundant log writing, move sleep to case *
sht_init - remove redundant srmode parsing

move sleep 20 to case error handling before repeated execution
get rid of redundant coding by moving 2 lines within for loop
check_for_primary - remove redundant log writing, move sleep to case * 
sht_init - remove redundant srmode parsing
Copy link
Member

@fmherschel fmherschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in principal good for me but needs to be tested before we should switch to the new code (before we merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants