Provide a skeleton of the new public library #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the efforts to split SUSEConnect in a way that some of the internal libraries can be used outside of SUSEConnect proper, we are starting to develop a small library inside of the new `pkg` directory. This new public Go library does not make as many assumptions as SUSEConnect does, and we strive to make it useful in environments which might be completely different than SUSEConnect. Signed-off-by: Miquel Sabaté Solà <[email protected]> Co-authored-by: Felix Schnizlein <[email protected]>
Our old LICENSE file was simply a header, and a bad one at that (e.g. it contained outdated information like the old SUSE HQ). Instead of that, reproduce in the LICENSE file the whole contents of the license as it's expected, and drop the LICENSE.LGPL license as it's then a duplicate. This has mainly been done because there are tools that were confused by our old setup, and we could not even show the Go documentation of our public library in https://pkg.go.dev/ because of this. Note also that we took LGPL v3+ this time around, whereas the old one was LGPL v2+. We believe this doesn't break anything on legal terms as the previous license was with the "or later" clause. Signed-off-by: Miquel Sabaté Solà <[email protected]>
paragjain0910
requested changes
Dec 10, 2024
felixsch
reviewed
Dec 10, 2024
Some structures were returned as values, which could be harmful when returning big blobs, but it was also not valid on situations in which we wanted to mutate the object itself. Hence, pass those as pointers instead. Reviewed-by: Parag Jain <[email protected]> Signed-off-by: Miquel Sabaté Solà <[email protected]>
There were a couple of directories which were temporarily used to iterate fast on the code being developed. We can scrap that now. Reviewed-by: Felix Schnizlein <[email protected]> Signed-off-by: Miquel Sabaté Solà <[email protected]>
paragjain0910
approved these changes
Dec 11, 2024
felixsch
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the efforts to split SUSEConnect in a way that some of the internal libraries can be used outside of SUSEConnect proper, we are starting to develop a small library inside of the new
pkgdirectory. This new public Go library does not make as many assumptions as SUSEConnect does, and we strive to make it useful in environments which might be completely different than SUSEConnect.Note also that we have also updated the
LICENSEfile. This has mainly been done because there are tools that were confused by our old setup, and we could not even show the Go documentation of our public library in https://pkg.go.dev/ because of this.