Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daria Vladykina <[email protected]>
  • Loading branch information
harneshalaka and dariavladykina authored Jan 22, 2025
1 parent de35a70 commit 612164b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
6 changes: 3 additions & 3 deletions references/networkmanager-nm-enabledisable.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</para>
<screen>&prompt.sudo;<command>nmcli networking on</command></screen>
<para>
Bear in mind that the command does not active manually disabled connections. To activate such a
Bear in mind that the command does not activate manually disabled connections. To activate such a
connection, proceed as described in the following procedure:
</para>

Expand Down Expand Up @@ -94,14 +94,14 @@ vnet0 ac196c81-0505-49f0-9328-b78e1746b4a9 tun vnet0

</procedure>
<para>
To disable <emphasis role="bold">all</emphasis> connection temporarily, run:
To disable <emphasis role="bold">all</emphasis> connections temporarily, run:
</para>
<screen>&prompt.sudo;<command>nmcli networking off</command></screen>

<note>
<title>Temporal changes only</title>
<para>
In both cases the changes persist only till the system reboots. After reboot, &nm; and
In both cases, the changes persist only till the system reboots. After reboot, &nm; and
connections are active again.
</para>
</note>
Expand Down
6 changes: 3 additions & 3 deletions references/networkmanager-nm-modify.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
</row>
<row>
<entry>ipv4.gateway</entry>
<entry>The property is the router address that your system use to reach networks beyond your local network</entry>
<entry>The property is the router address that your system uses to reach networks beyond your local network</entry>
<entry>An IP address of the gateway</entry>
</row>
<row>
Expand All @@ -103,8 +103,8 @@
</row>
<row>
<entry>802-11-wireless.ssid</entry>
<entry>The property renames a wi-fi network</entry>
<entry>A string representing the new wi-fi SSID</entry>
<entry>The property renames a Wi-Fi network</entry>
<entry>A string representing the new Wi-Fi SSID</entry>
</row>
<row>
<entry>connection.autoconnect</entry>
Expand Down
11 changes: 6 additions & 5 deletions tasks/networkmanager-nmcli-configure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ configured. The other connections can be used to fast
switch from one connection to another. For example, if the active connection is not available, &nm;
tries to connect the device to another configured connection.</para>
<para>The &nm; daemon manages network connections. You can interact with it
using a command-line interfaces: <command>nmcli</command> or ncurses interface:
using a command-line interface: <command>nmcli</command> or ncurses interface:
<command>nmtui</command>.</para>
<section><title>Creating an Ethernet connection</title>
<para>Configure the Ethernet connection using the <command>nmcli</command>
Expand All @@ -46,7 +46,7 @@ using a command-line interfaces: <command>nmcli</command> or ncurses interface:
<screen>&prompt.user;nmcli device</screen>
</step>
<step>
<para>View the list of connections to check if the profile name, you want to use, does not exist:</para>
<para>View the list of connections to make sure the profile name you want to use is not already taken:</para>
<screen>nmcli connection show</screen>
<para>The &nm; creates a profile for each Network Interface Controller (NIC). To connect the NIC to networks with different settings, you must create separate profiles for each network.</para>
</step>
Expand All @@ -63,7 +63,7 @@ using a command-line interfaces: <command>nmcli</command> or ncurses interface:
<screen>&prompt.sudo;nmcli connection modify <replaceable>CONNECTION_NAME</replaceable>
<replaceable>SETTING</replaceable> <replaceable>VALUE</replaceable></screen>
<para>
For example, automatic IP addresses assingment (DHCP or SLAAC) is enabled by default, you may want
For example, automatic IP addresses assignment (DHCP or SLAAC) is enabled by default, and you may want
to configure a static IP address:
</para>
<itemizedlist>
Expand Down Expand Up @@ -177,7 +177,7 @@ creation process or beforehand.</para></listitem>
p2p-dev-wlan0 wifi-p2p disconnected --
eth0 ethernet unavailable --
lo loopback unmanaged -- </screen>
<para>The list of available network interfaces appears. You can add to the bond also the devices that are not configured.
<para>The list of available network interfaces appears. You can also add devices that are not configured to the bond.
In the given list, <literal>p2p-dev-wlan0</literal> is not configured,
while <literal>virbr0</literal> is configured and has a connection profile.</para>
</step>
Expand Down Expand Up @@ -251,7 +251,8 @@ create a connection profile:</para>
</para>
</listitem>
<listitem>
<para>To use bond, bridge or VLAN devices as ports of the team, you can either create these devices while you create the team or you can create them in advance.</para>
<para>To use bond, bridge or VLAN devices as ports of the team, create them in advance or
when you create the team.</para>
</listitem>
</itemizedlist>
<procedure>
Expand Down

0 comments on commit 612164b

Please sign in to comment.