Last changes to reviewed smartdocs #274

tbazant · 2024-01-15T10:29:10Z

No description provided.

janajaeger

Very nice :) Just add the missing titles to the warnings you added and be done with it all! Thanks very much!

references/virtual-disk-cache-modes.xml

snippets/unsafe-cache-mode-warning.xml

dariavladykina

Hi, please see a few minor comments, thanks.

articles/vm-assign-pci-device.asm.xml

glues/virtualization-more-info.xml

references/systemd-securing-techniques.xml

tasks/systemd-analyze-security-service-files.xml

tasks/vm-assign-pci-device-troubleshooting.xml

Co-authored-by: Daria Vladykina <[email protected]>

updated cache modes

a8fe895

tbazant self-assigned this Jan 15, 2024

tbazant added 3 commits January 15, 2024 11:32

added warning snippet

ac981f9

disk cache modes finished

f18f33e

systemd securing is done

eb43ef2

tbazant marked this pull request as draft January 15, 2024 11:58

tbazant added 2 commits January 16, 2024 12:20

virtualization suggestions applied

83504dd

the rest is done

8e822e3

tbazant marked this pull request as ready for review January 17, 2024 08:35

janajaeger reviewed Jan 17, 2024

View reviewed changes

references/virtual-disk-cache-modes.xml Show resolved Hide resolved

snippets/unsafe-cache-mode-warning.xml Outdated Show resolved Hide resolved

Added titles to warnings

f1b09de

tbazant requested a review from dariavladykina January 17, 2024 09:54

dariavladykina reviewed Jan 17, 2024

View reviewed changes

Apply suggestions from code review

4b6d227

Co-authored-by: Daria Vladykina <[email protected]>

tbazant merged commit dbb77c4 into main Jan 18, 2024
11 checks passed

tbazant deleted the tbazant-smartdocs-applied-reviews branch January 18, 2024 10:51

Provide feedback