-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLE installation on x86_64 with Agama installer #417
SLE installation on x86_64 with Agama installer #417
Conversation
e0ed4a1
to
a44dad7
Compare
42dff01
to
0d827d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Souvik, thank you very much for handling this on such a short-term! I added some information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounix000 : Thanks a lot, looks good - just a few nitpicks from my side (and some things that @lvicoun already has covered). There is one issue we need to clarify with the portal squad I think (mentioned in one of my comments).
785aaa6
to
c640406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounix000 thanks! Please make sure to add the missing Bugzilla product string (to simplify bug reports), the rest of my comments is minor nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one line to remove (Bugzilla pointer, see my comment), otherwise looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounix000 : Many thanks, looks good from my side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Souvik, thanks for the updates! Just a generic comment regarding the products mentioned here. We plan to have a separate article for both products SLES and SLE4SAP, even though the installation procedure might be the same. That means not to mentioned the products simultaneously and use the generic entitiy &productname;. You can leave it now as it is, but this should be adjusted later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please see just minor nits here. Thanks!
20a979f
to
9f976bd
Compare
Description
Modular documentation for SLE installation on x86_64 with Agama installer
Are there any relevant issues/feature requests?
Is this (based on) existing content?
No, it's new content written from scratch.