Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE installation on x86_64 with Agama installer #417

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

sounix000
Copy link
Contributor

Description

Modular documentation for SLE installation on x86_64 with Agama installer

Are there any relevant issues/feature requests?

Is this (based on) existing content?

No, it's new content written from scratch.

@sounix000 sounix000 force-pushed the ssarkar/DOCTEAM-1675-SLE-Agama-installation-x86_64 branch from e0ed4a1 to a44dad7 Compare January 23, 2025 11:55
@sounix000 sounix000 marked this pull request as ready for review January 23, 2025 22:11
@sounix000 sounix000 force-pushed the ssarkar/DOCTEAM-1675-SLE-Agama-installation-x86_64 branch from 42dff01 to 0d827d5 Compare January 23, 2025 22:12
Copy link
Contributor

@lvicoun lvicoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Souvik, thank you very much for handling this on such a short-term! I added some information.

glues/sle-agama-installation-x86-64-more-info.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 : Thanks a lot, looks good - just a few nitpicks from my side (and some things that @lvicoun already has covered). There is one issue we need to clarify with the portal squad I think (mentioned in one of my comments).

DC-SLE-agama-installation-x86-64 Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
@sounix000 sounix000 force-pushed the ssarkar/DOCTEAM-1675-SLE-Agama-installation-x86_64 branch 2 times, most recently from 785aaa6 to c640406 Compare January 29, 2025 12:46
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 thanks! Please make sure to add the missing Bugzilla product string (to simplify bug reports), the rest of my comments is minor nitpicks.

articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one line to remove (Bugzilla pointer, see my comment), otherwise looks good to me

articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 : Many thanks, looks good from my side!

Copy link
Contributor

@lvicoun lvicoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Souvik, thanks for the updates! Just a generic comment regarding the products mentioned here. We plan to have a separate article for both products SLES and SLE4SAP, even though the installation procedure might be the same. That means not to mentioned the products simultaneously and use the generic entitiy &productname;. You can leave it now as it is, but this should be adjusted later.

articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see just minor nits here. Thanks!

articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
articles/sle-agama-installation-x86-64.asm.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
tasks/sle-agama-manual-installation-x86-64.xml Outdated Show resolved Hide resolved
glues/sle-agama-installation-x86-64-more-info.xml Outdated Show resolved Hide resolved
@sounix000 sounix000 force-pushed the ssarkar/DOCTEAM-1675-SLE-Agama-installation-x86_64 branch from 20a979f to 9f976bd Compare February 5, 2025 11:06
@sounix000 sounix000 merged commit c14ba6b into main Feb 5, 2025
11 checks passed
@sounix000 sounix000 deleted the ssarkar/DOCTEAM-1675-SLE-Agama-installation-x86_64 branch February 6, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants