Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCTEAM-1627: set enabled option to false in the yaml example #1784

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Amrita42
Copy link
Contributor

@Amrita42 Amrita42 commented Dec 11, 2024

PR creator: Description

Describe the overall goals of this pull request.

PR creator: Are there any relevant issues/feature requests?

DOCTEAM-1627

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE 15/openSUSE Leap 15.x

    • SLE 15 next/openSUSE Leap next (current main, no backport necessary)
    • SLE 15 SP6/openSUSE Leap 15.6
    • SLE 15 SP5/openSUSE Leap 15.5
    • SLE 15 SP4/openSUSE Leap 15.4
    • SLE 15 SP3/openSUSE Leap 15.3
    • SLE 15 SP2/openSUSE Leap 15.2
  • SLE 12

    • SLE 12 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

Sorry, something went wrong.

@Amrita42
Copy link
Contributor Author

@ngetahun
Applies to 15.4 and above versions as this yaml file exists in the mentioned sp versions
Have added enabled: false
but in this example I see the following:

products_enable:
      - SLES/15.3/x86_64
      - sle-module-python2/15.3/x86_64
    products_disable:
      - sle-module-legacy/15.3/x86_64
      - sle-module-cap-tools/15.3/x86_64 
is the key `enabled `different from `products_enable`?

@ngetahun
Copy link
Contributor

@ngetahun Applies to 15.4 and above versions as this yaml file exists in the mentioned sp versions Have added enabled: false but in this example I see the following:

products_enable:
      - SLES/15.3/x86_64
      - sle-module-python2/15.3/x86_64
    products_disable:
      - sle-module-legacy/15.3/x86_64
      - sle-module-cap-tools/15.3/x86_64 
is the key `enabled `different from `products_enable`?

Yeah they're different. enable controls an option for helm users to send data to scc. The other controls which products should be enabled for mirroring.

Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Amrita42 Amrita42 merged commit 20a3493 into main Dec 12, 2024
9 checks passed
@Amrita42 Amrita42 deleted the DOCTEAM-1627 branch December 12, 2024 14:14
Amrita42 added a commit that referenced this pull request Dec 12, 2024
Amrita42 added a commit that referenced this pull request Dec 12, 2024
Amrita42 added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants