Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/upgrade paths bsc#1174719 #142

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Bugfix/upgrade paths bsc#1174719 #142

merged 4 commits into from
Aug 19, 2020

Conversation

taroth21
Copy link
Contributor

@taroth21
Copy link
Contributor Author

@gao-yan : Could you please have a look? I guess for the upgrade from 12 SP5 to 15 SP2, I also need to add the pointer to https://documentation.suse.com/sle-ha/15-SP2/html/SLE-HA-all/cha-ha-clvm.html#sec-ha-clvm-migrate to the table?

@taroth21 taroth21 marked this pull request as draft August 13, 2020 09:24
gao-yan
gao-yan reviewed Aug 13, 2020
View reviewed changes
Copy link
Contributor

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me. Thanks a lot, @taroth21 !

@gao-yan
Copy link
Contributor

gao-yan commented Aug 13, 2020

@gao-yan : Could you please have a look? I guess for the upgrade from 12 SP5 to 15 SP2, I also need to add the pointer to https://documentation.suse.com/sle-ha/15-SP2/html/SLE-HA-all/cha-ha-clvm.html#sec-ha-clvm-migrate to the table?

Yes, I think so. @zzhou1 ?

@taroth21
Copy link
Contributor Author

taroth21 commented Aug 13, 2020 •
edited
Loading

@gao-yan : Could you please have a look? I guess for the upgrade from 12 SP5 to 15 SP2, I also need to add the pointer to https://documentation.suse.com/sle-ha/15-SP2/html/SLE-HA-all/cha-ha-clvm.html#sec-ha-clvm-migrate to the table?

Yes, I think so. @zzhou1 ?

@yan-gao: Thanks for reviewing! I have added the link to the section about 'Online Migration from Mirror LV to Cluster MD' now. Plan to merge this tomorrow, after Roger has had his say, too.

@taroth21 taroth21 mentioned this pull request Aug 13, 2020
Merged
3 tasks
@taroth21
Copy link
Contributor Author

Attaching the rendered PDF for easier review: cha-ha-migration_color_en.pdf

@zzhou1
Copy link
Contributor

zzhou1 commented Aug 19, 2020

@gao-yan : Could you please have a look? I guess for the upgrade from 12 SP5 to 15 SP2, I also need to add the pointer to https://documentation.suse.com/sle-ha/15-SP2/html/SLE-HA-all/cha-ha-clvm.html#sec-ha-clvm-migrate to the table?

Yes, I think so. @zzhou1 ?

@yan-gao: Thanks for reviewing! I have added the link to the section about 'Online Migration from Mirror LV to Cluster MD' now. Plan to merge this tomorrow, after Roger has had his say, too.

Yes, it makes sense to have the link.

Sorry for the late reply. I need find a better way to manage github notifications.

@taroth21 taroth21 marked this pull request as ready for review August 19, 2020 08:52
@taroth21 taroth21 merged commit 3c39893 into master Aug 19, 2020
@taroth21 taroth21 deleted the bugfix/upgrade-paths-bsc#1174719 branch August 19, 2020 08:54
taroth21 added a commit that referenced this pull request Aug 21, 2020
@taroth21
Bugfix/upgrade paths bsc#1174719 (#142)
075bcee 
* add missing entries for 12 SP4->12 SP5
* add missing entries for 12 SP5->15 SP2

(cherry picked from commit 3c39893)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gao-yan gao-yan gao-yan left review comments

@lproven lproven lproven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taroth21 @gao-yan @zzhou1 @lproven