-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic: get rid of outdated &hasi; entity #356
Conversation
- the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate
@tahliar : Could you please have a look and backport when approved and merged? For Code 12, the concept of modules & extensions did not exist yet in the way it was defined for Code 15 (and the 'Modules & Extensions Quick Start' does not exist). Therefore for 12 SP5 and SP4, you need to adjust the para/section in ha_concepts.xml, L. 53/54 accordingly. The rest of the changes should apply to both Code 15 and Code 12 versions. After this has been merged and backported, I would run the doc-kit updates for all branches to adjust the value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just two little nitpicks:
Co-authored-by: Tahlia Richardson <[email protected]>
@tahliar : Thanks, I have applied them now. |
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review * Further changes required for version 12 Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
* generic: get rid of outdated &hasi; entity - the following preparations where needed before we can fix the value of &productname; via doc-kit: * replace '[T,t]he &hasi;' with &productname; where appropriate * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate * update product-entities.ent * Apply suggestions from code review * Further changes required for version 12 Co-authored-by: Tahlia Richardson <[email protected]> --------- Co-authored-by: Tahlia Richardson <[email protected]>
PR creator: Description
To correct the productnames to the approved ones as per our terminology database several steps are needed. This is the first step:
The following preparations were needed before we can fix the value of
&productname;
via doc-kit:[T,t]he &hasi;
with&productname;
where appropriate[T,t]he &hasi;
with&ha; (software)
where appropriatePR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.