Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic: get rid of outdated &hasi; entity #356

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

taroth21
Copy link
Contributor

@taroth21 taroth21 commented Nov 6, 2023

PR creator: Description

To correct the productnames to the approved ones as per our terminology database several steps are needed. This is the first step:

The following preparations were needed before we can fix the value of &productname; via doc-kit:

  • replace [T,t]he &hasi; with &productname; where appropriate
  • replace [T,t]he &hasi; with &ha; (software) where appropriate

PR creator: Are there any relevant issues/feature requests?

  • jsc#DOCTEAM-1133

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE-HA 15
    • 15 next (current main, no backport necessary)
    • 15 SP5
    • 15 SP4
    • 15 SP3
    • 15 SP2
    • 15 SP1
  • SLE-HA 12
    • 12 SP5
    • 12 SP4

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate
@taroth21 taroth21 requested a review from tahliar November 6, 2023 09:36
@taroth21
Copy link
Contributor Author

taroth21 commented Nov 6, 2023

@tahliar : Could you please have a look and backport when approved and merged? For Code 12, the concept of modules & extensions did not exist yet in the way it was defined for Code 15 (and the 'Modules & Extensions Quick Start' does not exist). Therefore for 12 SP5 and SP4, you need to adjust the para/section in ha_concepts.xml, L. 53/54 accordingly. The rest of the changes should apply to both Code 15 and Code 12 versions.

After this has been merged and backported, I would run the doc-kit updates for all branches to adjust the value of &productname;.

Copy link
Collaborator

@tahliar tahliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just two little nitpicks:

xml/ha_concepts.xml Outdated Show resolved Hide resolved
xml/ha_concepts.xml Outdated Show resolved Hide resolved
Co-authored-by: Tahlia Richardson <[email protected]>
@taroth21
Copy link
Contributor Author

taroth21 commented Nov 7, 2023

@tahliar : Thanks, I have applied them now.

@tahliar tahliar merged commit 3aa5447 into main Nov 8, 2023
@tahliar tahliar deleted the taroth/remove_hasi branch November 8, 2023 03:30
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

* Further changes required for version 12

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
tahliar added a commit that referenced this pull request Nov 8, 2023
* generic: get rid of outdated &hasi; entity

- the following preparations where needed before we can fix the value
  of &productname; via doc-kit:
  * replace '[T,t]he &hasi;' with &productname; where appropriate
  * replace '[T,t]he &hasi;' with '&ha; (software)' where appropriate

* update product-entities.ent

* Apply suggestions from code review

* Further changes required for version 12

Co-authored-by: Tahlia Richardson <[email protected]>

---------

Co-authored-by: Tahlia Richardson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants