-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on using --use-ssh-agent #372
Conversation
It's now supported for more tasks jsc#PED-7399
jsc#PED-7399
Admin guide: I removed the user privileges note (https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-config-basics.html#cha-ha-manual-config) and replaced it with this: |
It is great to group crmsh operations into 2 categories. However, I think
is not so accuracy. The real privileges needed are read/write access to low-level configurations files, such as And SSH operations are needed for crmsh to perform the above actions among different cluster nodes. On the contrary, cib is owned by hacluster user, and is synchronized across the cluster by pacemaker. So hacluster can operates it and not ssh operations are needed. Loop in @liangxin1300 and @zzhou1 here. Please review the above description, and see whether it is necessary to include these details in documents.
I think creating And similarly in Section 4.8 Bring the cluster online, |
Yeah. Could be something like as below in my language, """
Yes, use the "ssh" stage is a better and safer approach. |
Thanks @zzhou1 and @nicholasyang2022! I've made some changes that hopefully address all your feedback. 1. Added some detail about the I think it's fine to leave in 2. Added some detail to the SSH requirement in 2.4 Other requirements and recommendations 3. Updated the new section |
I've now also updated Appendix D. Here's what I did: 1. Removed 2. Removed 3. Consolidated Appendix D down to just the sudo privileges part (PDF because it's a whole section): 4. Updated the regulatory requirements note (again) to (re)include a link to the Appendix: |
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort! Only one minor change request.
3. Consolidated Appendix D down to just the sudo privileges part (PDF because it's a whole section):
Only one comment:
It's better to remove the space before the asterisk as below.
Cmnd_Alias HA_ALLOWED = /bin/su, /usr/sbin/crm report*
Otherwise, I get the following confusing error message and spend a couple of hours to figure it out
hareport@15sp6-1:~> sudo crm report
[sudo] password for hareport:
Sorry, user hareport is not allowed to execute '/usr/sbin/crm report' as root on 15sp6-1.
Thanks @nicholasyang2022 and @zzhou1! I've fixed the extra space and will move this on to editorial review now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor nit. Thanks!
Co-authored-by: Daria Vladykina <[email protected]>
PR creator: Description
Added a section on logging in, and other bits and pieces.
PR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.