-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how fence_kdump works #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsc#1228931 jsc#DOCTEAM-537
zzhou1
suggested changes
Sep 19, 2024
Co-authored-by: Roger Zhou <[email protected]>
Thanks @zzhou1! I applied your fixes and made a couple of little edits. Let me know if you're happy with it :) |
zzhou1
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, Tahlia!
dariavladykina
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
tahliar
added a commit
that referenced
this pull request
Sep 24, 2024
* Clarify how fence_kdump works bsc#1228931 jsc#DOCTEAM-537 * Apply suggestions from code review Co-authored-by: Roger Zhou <[email protected]> * Small edits --------- Co-authored-by: Roger Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR creator: Description
Hopefully this makes the fence_kdump example clearer.
PR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.